Automatically fire AX events on Win based on tree changes

Automatically fire AX events on Win based on tree changes

This change uses tree changes to automatically determine
which Win AX events to fire, rather than getting the events
directly from Blink. The code to fire events from Blink is
removed for OS_WIN in this change.

A previous change did this for Mac. Subsequent changes will
do the same for Linux, Android, and Chrome OS, and then we can
delete all of the code that fires specific events from Blink,
and just mark AX nodes as dirty instead.

BUG=699438
Review-Url: https://codereview.chromium.org/2957973003
Cr-Commit-Position: refs/heads/master@{#490471}
Committed: https://chromium.googlesource.com/chromium/src/+/3674d6f0ac52b4c7e3c21aa76f1cf842692ec692

[dmazzoni, 2017-06-27 20:57:53]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-06-27 20:58:12]

dmazzoni@chromium.org changed reviewers:
+ nektar@chromium.org

[nektarios, 2017-06-30 21:41:55]

+void BrowserAccessibilityManagerWin::OnNodeDataWillChange(
+    ui::AXTree* tree,
+    const ui::AXNodeData& old_node_data,
+    const ui::AXNodeData& new_node_data) {
+  if (new_node_data.child_ids != old_node_data.child_ids &&
+      new_node_data.role != ui::AX_ROLE_STATIC_TEXT) {
+    tree_events_[new_node_data.id].insert(ui::AX_EVENT_CHILDREN_CHANGED);

Do we need to check for line break role as well?
There is a method for this on AXPlatformNodeBase. IsTextOnlyObject.

+++
b/content/test/data/accessibility/event/aria-combo-box-focus-expected-win.txt
-EVENT_OBJECT_FOCUS on role=ROLE_SYSTEM_LISTITEM name="Apple"
FOCUSED,FOCUSABLE,SELECTABLE
 IA2_EVENT_TEXT_CARET_MOVED on role=ROLE_SYSTEM_COMBOBOX
EXPANDED,FOCUSABLE,HASPOPUP
IA2_STATE_EDITABLE,IA2_STATE_SUPPORTS_AUTOCOMPLETION,IA2_STATE_VERTICAL
+EVENT_OBJECT_FOCUS on role=ROLE_SYSTEM_LISTITEM name="Apple"
FOCUSED,FOCUSABLE,SELECTABLE

Shouldn't the caret moved event come after focus? Wouldn't screen readers /
magnifiers be confused?
I understand it's hard to change the order since the node is already
unserialized before focus events are handled, so you may ignore this.

[nektarios, 2017-06-30 21:42:01]

lgtm

[dmazzoni, 2017-07-27 17:57:52]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-27 17:58:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-27 19:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-27 19:03:09]

Dry run: CQ cannot get SignCLA result. Please try later.

[dmazzoni, 2017-07-27 21:44:59]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-27 21:45:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-07-27 21:47:43]

FYI, I'm planning to land this now. I manually audited
all of the events and also manually tested with NVDA
and JAWS. Still, it's possible I missed something, so
this may be a possible culprit if you see regressions
on Windows.

[commit-bot: I haz the power, 2017-07-28 00:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-28 00:29:29]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dmazzoni, 2017-07-28 16:50:54]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-07-28 16:50:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nektar@chromium.org
Link to the patchset: https://codereview.chromium.org/2957973003/#ps40001
(title: "Audit all events, manually test with JAWS and NVDA")

[commit-bot: I haz the power, 2017-07-28 16:51:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-28 16:58:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-28 16:58:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2017-07-28 17:13:12]

core/ LGTM

[dmazzoni, 2017-07-28 18:16:10]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-07-28 18:16:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-28 18:27:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1501265770440060,
"parent_rev": "152536c49f55b8be4758892c0f44f336145cca67", "commit_rev":
"3674d6f0ac52b4c7e3c21aa76f1cf842692ec692"}

[commit-bot: I haz the power, 2017-07-28 18:27:43]

Description was changed from

==========
Automatically fire AX events on Win based on tree changes

This change uses tree changes to automatically determine
which Win AX events to fire, rather than getting the events
directly from Blink. The code to fire events from Blink is
removed for OS_WIN in this change.

A previous change did this for Mac. Subsequent changes will
do the same for Linux, Android, and Chrome OS, and then we can
delete all of the code that fires specific events from Blink,
and just mark AX nodes as dirty instead.

BUG=699438
==========

to

==========
Automatically fire AX events on Win based on tree changes

This change uses tree changes to automatically determine
which Win AX events to fire, rather than getting the events
directly from Blink. The code to fire events from Blink is
removed for OS_WIN in this change.

A previous change did this for Mac. Subsequent changes will
do the same for Linux, Android, and Chrome OS, and then we can
delete all of the code that fires specific events from Blink,
and just mark AX nodes as dirty instead.

BUG=699438

Review-Url: https://codereview.chromium.org/2957973003
Cr-Commit-Position: refs/heads/master@{#490471}
Committed:
https://chromium.googlesource.com/chromium/src/+/3674d6f0ac52b4c7e3c21aa76f1c...
==========

[commit-bot: I haz the power, 2017-07-28 18:27:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3674d6f0ac52b4c7e3c21aa76f1c...