content/renderer/accessibility/blink_ax_tree_source.cc - Issue 2957973003: Automatically fire AX events on Win based on tree changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2957973003: Automatically fire AX events on Win based on tree changes (Closed)

Patch Set: Audit all events, manually test with JAWS and NVDA Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index f0f3f6161d680e71d726c924f3e147d83db0b3e3..d8d2b26c7f9447c87374368c0f0cc79712fcb435 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -101,7 +101,8 @@ class AXContentNodeDataSparseAttributeAdapter

const WebAXObject& value) override {

switch (attribute) {

case WebAXObjectAttribute::kAriaActiveDescendant:

- dst_->AddIntAttribute(ui::AX_ATTR_ACTIVEDESCENDANT_ID, value.AxID());

+ // TODO(dmazzoni): WebAXObject::ActiveDescendant currently returns

+ // more information than the sparse interface does.

break;

case WebAXObjectAttribute::kAriaDetails:

dst_->AddIntAttribute(ui::AX_ATTR_DETAILS_ID, value.AxID());