Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 2957973003: Automatically fire AX events on Win based on tree changes (Closed)
Patch Set: Audit all events, manually test with JAWS and NVDA Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
index 30099107b3367fd38b4c252f607dfce51932bd38..87ee8196c4134ac9c6214a0ca241c31032dd5ea2 100644
--- a/content/browser/accessibility/browser_accessibility_manager.cc
+++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -434,9 +434,14 @@ void BrowserAccessibilityManager::OnAccessibilityEvents(
ui::AXEvent event_type = detail.event_type;
-#if defined(OS_MACOSX)
- if (event_type != ui::AX_EVENT_HOVER)
+// On Mac and Windows, nearly all events are now fired implicitly,
+// so we should ignore most events from the renderer.
+#if defined(OS_MACOSX) || defined(OS_WIN)
+ if (event_type != ui::AX_EVENT_HOVER &&
+ event_type != ui::AX_EVENT_LOCATION_CHANGED &&
+ event_type != ui::AX_EVENT_SCROLLED_TO_ANCHOR) {
continue;
+ }
#endif // !defined(OS_MACOSX)
if (event_type == ui::AX_EVENT_FOCUS ||

Powered by Google App Engine
This is Rietveld 408576698