Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2957533002: Enable ThinLTO for POSIX LTO by default on Linux, take 2. (Closed)

Created:
3 years, 6 months ago by pcc1
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ThinLTO for POSIX LTO by default on Linux, take 2. Previous attempt: https://codereview.chromium.org/2939373002 It was reverted because it caused large thinlto-cache directories to be created on the perf bots, which were also being unnecessarily included in package archives. This has been addressed in two ways: 1) the bots have been taught to exclude thinlto-cache from package archives (see https://chromium-review.googlesource.com/c/544530/). 2) this change limits the size of the cache to 10% of available disk space. BUG=660216, 735651 R=dpranke@chromium.org,thakis@chromium.org TBR=thomasanderson@chromium.org Review-Url: https://codereview.chromium.org/2957533002 Cr-Commit-Position: refs/heads/master@{#481944} Committed: https://chromium.googlesource.com/chromium/src/+/9a6cc80b32bb5522fe262e1f60a9995dabf9dcbb

Patch Set 1 #

Patch Set 2 : New patch #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_jessie View 1 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 15 (7 generated)
pcc1
3 years, 6 months ago (2017-06-23 04:05:49 UTC) #1
Tom Anderson
chrome/installer/linux lgtm
3 years, 6 months ago (2017-06-23 04:54:16 UTC) #4
Nico
lgtm
3 years, 6 months ago (2017-06-23 11:36:58 UTC) #7
Dirk Pranke
https://codereview.chromium.org/2957533002/diff/20001/chrome/installer/linux/debian/expected_deps_x64_jessie File chrome/installer/linux/debian/expected_deps_x64_jessie (right): https://codereview.chromium.org/2957533002/diff/20001/chrome/installer/linux/debian/expected_deps_x64_jessie#newcode7 chrome/installer/linux/debian/expected_deps_x64_jessie:7: libdbus-1-3 (>= 1.2.14) why is there a deps change ...
3 years, 6 months ago (2017-06-23 16:01:29 UTC) #8
pcc1
https://codereview.chromium.org/2957533002/diff/20001/chrome/installer/linux/debian/expected_deps_x64_jessie File chrome/installer/linux/debian/expected_deps_x64_jessie (right): https://codereview.chromium.org/2957533002/diff/20001/chrome/installer/linux/debian/expected_deps_x64_jessie#newcode7 chrome/installer/linux/debian/expected_deps_x64_jessie:7: libdbus-1-3 (>= 1.2.14) On 2017/06/23 16:01:29, Dirk Pranke wrote: ...
3 years, 6 months ago (2017-06-23 16:44:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957533002/20001
3 years, 6 months ago (2017-06-23 16:44:40 UTC) #11
Dirk Pranke
https://codereview.chromium.org/2957533002/diff/20001/chrome/installer/linux/debian/expected_deps_x64_jessie File chrome/installer/linux/debian/expected_deps_x64_jessie (right): https://codereview.chromium.org/2957533002/diff/20001/chrome/installer/linux/debian/expected_deps_x64_jessie#newcode7 chrome/installer/linux/debian/expected_deps_x64_jessie:7: libdbus-1-3 (>= 1.2.14) On 2017/06/23 16:44:21, pcc1 wrote: > ...
3 years, 6 months ago (2017-06-23 16:45:20 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 17:35:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a6cc80b32bb5522fe262e1f60a9...

Powered by Google App Engine
This is Rietveld 408576698