Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2003143002: Fix expectations for debian deps. (Closed)

Created:
4 years, 7 months ago by krasin
Modified:
4 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix expectations for debian deps. The change is due to launching LTO ([1], [2]) on Linux, which eliminated some of the unused symbols deps, thus decreasing the effective version of libdbus-1-3 Chrome depends on. BUG=453195 [1] http://llvm.org/docs/LinkTimeOptimization.html [2] https://codereview.chromium.org/2003733004 (actually try bots had run; the line below is to bypass a slow flaky bot) NOTRY=true Committed: https://crrev.com/0fe758fd6d99cadd1a533018e5ccce602a8b6cd5 Cr-Commit-Position: refs/heads/master@{#395411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/installer/linux/debian/expected_deps_x64 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
krasin
The error message from the bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/11395/steps/compile/logs/stdio python ../../chrome/installer/linux/flock_make_package.py linux_package.lock installer/debian/build.sh -o ../Release -b ../Release ...
4 years, 7 months ago (2016-05-23 20:05:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003143002/1
4 years, 7 months ago (2016-05-23 20:06:02 UTC) #4
krasin
4 years, 7 months ago (2016-05-23 20:07:49 UTC) #7
Michael Moss
lgtm
4 years, 7 months ago (2016-05-23 20:07:58 UTC) #8
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-23 20:15:35 UTC) #10
krasin
All trybots but one succeeded (because they don't actually check for this file). One failed ...
4 years, 7 months ago (2016-05-23 21:00:01 UTC) #12
mmoss
On 2016/05/23 21:00:01, krasin wrote: > All trybots but one succeeded (because they don't actually ...
4 years, 7 months ago (2016-05-23 21:01:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003143002/1
4 years, 7 months ago (2016-05-23 21:02:20 UTC) #16
krasin
> If compile passed, that's what matters. That's the where packages are generated, > and ...
4 years, 7 months ago (2016-05-23 21:02:23 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 21:08:21 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 21:10:39 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fe758fd6d99cadd1a533018e5ccce602a8b6cd5
Cr-Commit-Position: refs/heads/master@{#395411}

Powered by Google App Engine
This is Rietveld 408576698