Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2939373002:
Enable ThinLTO for POSIX LTO by default on Linux. (Closed)
DescriptionEnable ThinLTO for POSIX LTO by default on Linux.
This is a reland of the remaining part of
https://codereview.chromium.org/2831213006 .
The binary size regression has been addressed by disabling ThinLTO
whole-program optimizations and improving the quality of unoptimized
code.
BUG=660216
R=thakis@chromium.org,hans@chromium.org
Review-Url: https://codereview.chromium.org/2939373002
Cr-Commit-Position: refs/heads/master@{#480144}
Committed: https://chromium.googlesource.com/chromium/src/+/5cb9983f12f300422c16ba812c2d5cdeb278cb74
Patch Set 1 #Patch Set 2 : Also check allow_posix_link_time_opt #Messages
Total messages: 19 (9 generated)
The CQ bit was checked by pcc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm Do you have any numbers on how much faster this makes links?
On 2017/06/16 17:29:08, Nico wrote: > lgtm > > Do you have any numbers on how much faster this makes links? According to some .ninja_log files that I have lying around this reduces full chrome link times from ~2800 seconds to ~900 seconds. This might have been from before I switched from --lto-O2 to --lto-O0 so the actual numbers may be even smaller.
The CQ bit was unchecked by pcc@chromium.org
The CQ bit was checked by pcc@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Ok, so it's much faster, but still pretty slow. At llvmconf I think mehdi said he wants thinlto to be fast enough that people can almost use it for general development -- is that still realistic? On Jun 16, 2017 2:21 PM, "commit-bot@chromium.org via codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Try jobs failed on following builders: > linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux > (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/ > builders/linux_chromium_compile_dbg_ng/builds/319352) > > https://codereview.chromium.org/2939373002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Note that the numbers I quoted were for a full link. Incremental links should be much faster. Last time I measured no-op incremental links of chrome were less than a minute and I have some patches under review that reduce it to about 30 seconds. Peter On Fri, Jun 16, 2017 at 11:36 AM, Nico Weber <thakis@chromium.org> wrote: > Ok, so it's much faster, but still pretty slow. At llvmconf I think mehdi > said he wants thinlto to be fast enough that people can almost use it for > general development -- is that still realistic? > > On Jun 16, 2017 2:21 PM, "commit-bot@chromium.org via > codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com> > wrote: >> >> Try jobs failed on following builders: >> linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux >> (JOB_FAILED, >> >> http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) >> >> https://codereview.chromium.org/2939373002/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by pcc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2939373002/#ps20001 (title: "Also check allow_posix_link_time_opt")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497638664973820,
"parent_rev": "26d37417b94316335063fd5c51be08514d949999", "commit_rev":
"5cb9983f12f300422c16ba812c2d5cdeb278cb74"}
Message was sent while issue was closed.
Description was changed from ========== Enable ThinLTO for POSIX LTO by default on Linux. This is a reland of the remaining part of https://codereview.chromium.org/2831213006 . The binary size regression has been addressed by disabling ThinLTO whole-program optimizations and improving the quality of unoptimized code. BUG=660216 R=thakis@chromium.org,hans@chromium.org ========== to ========== Enable ThinLTO for POSIX LTO by default on Linux. This is a reland of the remaining part of https://codereview.chromium.org/2831213006 . The binary size regression has been addressed by disabling ThinLTO whole-program optimizations and improving the quality of unoptimized code. BUG=660216 R=thakis@chromium.org,hans@chromium.org Review-Url: https://codereview.chromium.org/2939373002 Cr-Commit-Position: refs/heads/master@{#480144} Committed: https://chromium.googlesource.com/chromium/src/+/5cb9983f12f300422c16ba812c2d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5cb9983f12f300422c16ba812c2d...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2953943002/ by pcc@chromium.org. The reason for reverting is: Breaks chromium.perf builder. BUG=735651. |
