Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2957473002: [WebAPKs] Display same text for menu & engagement banner v2 (Closed)

Created:
3 years, 6 months ago by pkotwicz
Modified:
3 years, 5 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebAPKs] Display same text for menu & engagement banner This CL changes the text of the banner displayed when installing a WebAPK from the app menu to match the text of the banner displayed via the engagement checks. Using the same text in both banners prevents creating a second banner if a user tries to install a WebAPK from the app menu if the "user engagement A2HS" banner is already visible. BUG=728300 Review-Url: https://codereview.chromium.org/2957473002 Cr-Commit-Position: refs/heads/master@{#482690} Committed: https://chromium.googlesource.com/chromium/src/+/d4d01caea21d315b49a92cf9ad71f034e323f766

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into same_infobar_title000 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M chrome/browser/android/banners/app_banner_infobar_delegate_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/android/banners/app_banner_infobar_delegate_android.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
pkotwicz
Dominick, can you please take a look? This CL depends on https://codereview.chromium.org/2950113003/ and https://codereview.chromium.org/2948313002/
3 years, 6 months ago (2017-06-22 22:25:14 UTC) #3
dominickn
lgtm, this is great. Thanks!
3 years, 6 months ago (2017-06-23 01:16:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957473002/20001
3 years, 5 months ago (2017-06-27 17:36:40 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 18:45:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4d01caea21d315b49a92cf9ad71...

Powered by Google App Engine
This is Rietveld 408576698