Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2957473002: [WebAPKs] Display same text for menu & engagement banner v2 (Closed)
Patch Set: Merge branch 'master' into same_infobar_title000 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 84126a3eba34e8cee270633232ec279efee77708..f50e444cf6cea7165e1d9e932287d927168345db 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -245,12 +245,11 @@ void AppBannerManagerAndroid::ShowBanner() {
DCHECK(contents);
if (native_app_data_.is_null()) {
- std::unique_ptr<ShortcutInfo> info =
- CreateShortcutInfo(manifest_url_, manifest_, primary_icon_url_,
- badge_icon_url_, can_install_webapk_);
if (AppBannerInfoBarDelegateAndroid::Create(
- contents, GetWeakPtr(), info->name, std::move(info), primary_icon_,
- badge_icon_, event_request_id(), can_install_webapk_,
+ contents, GetWeakPtr(),
+ CreateShortcutInfo(manifest_url_, manifest_, primary_icon_url_,
+ badge_icon_url_, can_install_webapk_),
+ primary_icon_, badge_icon_, event_request_id(), can_install_webapk_,
webapk::INSTALL_SOURCE_BANNER)) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);

Powered by Google App Engine
This is Rietveld 408576698