Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2957473002: [WebAPKs] Display same text for menu & engagement banner v2 (Closed)
Patch Set: Merge branch 'master' into same_infobar_title000 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
index b9229eb88efa2a24ef9b62f51fa8386300560155..796faab00f333c21ef7e323f07832bd6b55f55a2 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
@@ -41,7 +41,6 @@ namespace banners {
bool AppBannerInfoBarDelegateAndroid::Create(
content::WebContents* web_contents,
base::WeakPtr<AppBannerManager> weak_manager,
- const base::string16& app_title,
std::unique_ptr<ShortcutInfo> shortcut_info,
const SkBitmap& primary_icon,
const SkBitmap& badge_icon,
@@ -55,8 +54,8 @@ bool AppBannerInfoBarDelegateAndroid::Create(
auto infobar_delegate =
base::WrapUnique(new banners::AppBannerInfoBarDelegateAndroid(
- weak_manager, app_title, std::move(shortcut_info), primary_icon,
- badge_icon, event_request_id, is_webapk, webapk_install_source));
+ weak_manager, std::move(shortcut_info), primary_icon, badge_icon,
+ event_request_id, is_webapk, webapk_install_source));
auto* raw_delegate = infobar_delegate.get();
auto infobar = base::MakeUnique<AppBannerInfoBarAndroid>(
std::move(infobar_delegate), url, is_webapk);
@@ -203,7 +202,6 @@ void AppBannerInfoBarDelegateAndroid::UpdateStateForInstalledWebAPK(
AppBannerInfoBarDelegateAndroid::AppBannerInfoBarDelegateAndroid(
base::WeakPtr<AppBannerManager> weak_manager,
- const base::string16& app_title,
std::unique_ptr<ShortcutInfo> shortcut_info,
const SkBitmap& primary_icon,
const SkBitmap& badge_icon,
@@ -211,7 +209,7 @@ AppBannerInfoBarDelegateAndroid::AppBannerInfoBarDelegateAndroid(
bool is_webapk,
webapk::InstallSource webapk_install_source)
: weak_manager_(weak_manager),
- app_title_(app_title),
+ app_title_(shortcut_info->name),
shortcut_info_(std::move(shortcut_info)),
primary_icon_(primary_icon),
badge_icon_(badge_icon),

Powered by Google App Engine
This is Rietveld 408576698