[reland] Move navigation-induced hiding of form-validation-bubble to the browser process.

[reland] Move navigation-induced hiding of form-validation-bubble to the browser process.

Moving hiding of the form validation bubble to the browser process has
the following benefits:
- It allows simplifying/removing code from Blink (in particular it
  allows removing some of the code added in r459701).
- It makes the hiding immune against compromised renderers.
- It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC
  gets filtered out (i.e. see CanSendWhileSwappedOut method in
  content::SwappedOutMessages).  This in turn will allow relanding
  of r479538.

BUG=733940
TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed.
TBR=alexmos@chromium.org

Review-Url: https://codereview.chromium.org/2956673002
Cr-Commit-Position: refs/heads/master@{#482327}
Committed: https://chromium.googlesource.com/chromium/src/+/041634d6b54ab33ca9c506ec137fc4961d7792f1

[Łukasz Anforowicz, 2017-06-23 21:20:47]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 21:21:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-23 23:09:18]

lukasza@chromium.org changed reviewers:
+ tkent@chromium.org

[Łukasz Anforowicz, 2017-06-23 23:09:19]

tkent@ could you PTAL?

This is a reland of https://codereview.chromium.org/2949593003, except that here
I am not removing the ValidationMessageClient::DocumentDetached method (when
working on the previous CL, I was trying to undo parts of r459701 that are now
unnecessary and I've incorrectly thought that DocumentDetached was introduced by
r459701 [bad reading comprehension of diffs... my fault]).

In this reland we shouldn't anymore hit leaks of Document that were introduced
by the original CL (where ValidationMessageClient keeps the Document alive via
|current_anchor_|).

[commit-bot: I haz the power, 2017-06-23 23:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 23:35:50]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-06-25 23:07:36]

third_party/WebKit lgtm

[Łukasz Anforowicz, 2017-06-26 16:10:14]

Description was changed from

==========
[reland] Move navigation-induced hiding of form-validation-bubble to the browser
process.

Moving hiding of the form validation bubble to the browser process has
the following benefits:
- It allows simplifying/removing code from Blink (in particular it
  allows removing some of the code added in r459701).
- It makes the hiding immune against compromised renderers.
- It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC
  gets filtered out (i.e. see CanSendWhileSwappedOut method in
  content::SwappedOutMessages).  This in turn will allow relanding
  of r479538.

BUG=733940
TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed.
==========

to

==========
[reland] Move navigation-induced hiding of form-validation-bubble to the browser
process.

Moving hiding of the form validation bubble to the browser process has
the following benefits:
- It allows simplifying/removing code from Blink (in particular it
  allows removing some of the code added in r459701).
- It makes the hiding immune against compromised renderers.
- It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC
  gets filtered out (i.e. see CanSendWhileSwappedOut method in
  content::SwappedOutMessages).  This in turn will allow relanding
  of r479538.

BUG=733940
TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed.
TBR=alexmos@chromium.org
==========

[Łukasz Anforowicz, 2017-06-26 16:11:57]

lukasza@chromium.org changed reviewers:
+ alexmos@chromium.org

[Łukasz Anforowicz, 2017-06-26 16:11:58]

alexmos@, I will just add you to TBR, because there are no //content changes
here that weren't already present and reviewed by you in the original CL @
https://crrev.com/2949593003.

[Łukasz Anforowicz, 2017-06-26 16:12:08]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-06-26 16:12:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 18:20:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498493528246630,
"parent_rev": "a2c0592a18bd438cedc03892bdaaf54132f18898", "commit_rev":
"a76d9c03eb14a148686f876476a8d70a0e08879c"}

[commit-bot: I haz the power, 2017-06-26 18:21:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498493528246630,
"parent_rev": "60cc8c2a46befaf712703f4889002ecfc1b37ab7", "commit_rev":
"041634d6b54ab33ca9c506ec137fc4961d7792f1"}

[commit-bot: I haz the power, 2017-06-26 18:21:26]

Description was changed from

==========
[reland] Move navigation-induced hiding of form-validation-bubble to the browser
process.

Moving hiding of the form validation bubble to the browser process has
the following benefits:
- It allows simplifying/removing code from Blink (in particular it
  allows removing some of the code added in r459701).
- It makes the hiding immune against compromised renderers.
- It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC
  gets filtered out (i.e. see CanSendWhileSwappedOut method in
  content::SwappedOutMessages).  This in turn will allow relanding
  of r479538.

BUG=733940
TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed.
TBR=alexmos@chromium.org
==========

to

==========
[reland] Move navigation-induced hiding of form-validation-bubble to the browser
process.

Moving hiding of the form validation bubble to the browser process has
the following benefits:
- It allows simplifying/removing code from Blink (in particular it
  allows removing some of the code added in r459701).
- It makes the hiding immune against compromised renderers.
- It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC
  gets filtered out (i.e. see CanSendWhileSwappedOut method in
  content::SwappedOutMessages).  This in turn will allow relanding
  of r479538.

BUG=733940
TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed.
TBR=alexmos@chromium.org

Review-Url: https://codereview.chromium.org/2956673002
Cr-Commit-Position: refs/heads/master@{#482327}
Committed:
https://chromium.googlesource.com/chromium/src/+/041634d6b54ab33ca9c506ec137f...
==========

[commit-bot: I haz the power, 2017-06-26 18:21:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/041634d6b54ab33ca9c506ec137f...