Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp

Issue 2956673002: [reland] Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)
Patch Set: Keep ValidationMessageClient::DocumentDetached method. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp
diff --git a/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp b/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp
index f2e3c3bc44b3c0a71619a3ce8c4b2ea704e121cc..7eb5f345b4ffdfa17687b57604623fbc973667e8 100644
--- a/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp
+++ b/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp
@@ -115,16 +115,11 @@ bool ValidationMessageClientImpl::IsValidationMessageVisible(
return current_anchor_ == &anchor;
}
-void ValidationMessageClientImpl::WillUnloadDocument(const Document& document) {
+void ValidationMessageClientImpl::DocumentDetached(const Document& document) {
if (current_anchor_ && current_anchor_->GetDocument() == document)
HideValidationMessage(*current_anchor_);
}
-void ValidationMessageClientImpl::DocumentDetached(const Document& document) {
- DCHECK(!current_anchor_ || current_anchor_->GetDocument() != document)
- << "willUnloadDocument() should be called beforehand.";
-}
-
void ValidationMessageClientImpl::CheckAnchorStatus(TimerBase*) {
DCHECK(current_anchor_);
if (MonotonicallyIncreasingTime() >= finish_time_ || !CurrentView()) {
« no previous file with comments | « third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698