Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2956673002: [reland] Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)
Patch Set: Keep ValidationMessageClient::DocumentDetached method. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All
3 * Rights Reserved. 3 * Rights Reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 246
247 void Page::SetMainFrame(Frame* main_frame) { 247 void Page::SetMainFrame(Frame* main_frame) {
248 // Should only be called during initialization or swaps between local and 248 // Should only be called during initialization or swaps between local and
249 // remote frames. 249 // remote frames.
250 // FIXME: Unfortunately we can't assert on this at the moment, because this 250 // FIXME: Unfortunately we can't assert on this at the moment, because this
251 // is called in the base constructor for both LocalFrame and RemoteFrame, 251 // is called in the base constructor for both LocalFrame and RemoteFrame,
252 // when the vtables for the derived classes have not yet been setup. 252 // when the vtables for the derived classes have not yet been setup.
253 main_frame_ = main_frame; 253 main_frame_ = main_frame;
254 } 254 }
255 255
256 void Page::WillUnloadDocument(const Document& document) {
257 if (validation_message_client_)
258 validation_message_client_->WillUnloadDocument(document);
259 }
260
261 void Page::DocumentDetached(Document* document) { 256 void Page::DocumentDetached(Document* document) {
262 pointer_lock_controller_->DocumentDetached(document); 257 pointer_lock_controller_->DocumentDetached(document);
263 context_menu_controller_->DocumentDetached(document); 258 context_menu_controller_->DocumentDetached(document);
264 if (validation_message_client_) 259 if (validation_message_client_)
265 validation_message_client_->DocumentDetached(*document); 260 validation_message_client_->DocumentDetached(*document);
266 hosts_using_features_.DocumentDetached(*document); 261 hosts_using_features_.DocumentDetached(*document);
267 } 262 }
268 263
269 bool Page::OpenedByDOM() const { 264 bool Page::OpenedByDOM() const {
270 return opened_by_dom_; 265 return opened_by_dom_;
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 : chrome_client(nullptr), 677 : chrome_client(nullptr),
683 context_menu_client(nullptr), 678 context_menu_client(nullptr),
684 editor_client(nullptr), 679 editor_client(nullptr),
685 spell_checker_client(nullptr) {} 680 spell_checker_client(nullptr) {}
686 681
687 Page::PageClients::~PageClients() {} 682 Page::PageClients::~PageClients() {}
688 683
689 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 684 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
690 685
691 } // namespace blink 686 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/core/page/ValidationMessageClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698