Rename SingleLogSource to SingleLogFileLogSource

Rename SingleLogSource to SingleLogFileLogSource

Since there is now a class SingleDebugDaemonLogSource, the old
name "SingleLogSource" is ambiguous. Rename it to indicate that the
logs come from a log file.

Also refactored the use of SingleLogSource in feedbackPrivate API:
- Use the base interface class SystemLogsSource instead, in
  LogSourceAccessManager.
- Convert from feedback_private::LogSource directly to a
  SystemLogSource in SingleLogSourceFactory. Conversion of enums is
  internal to SingleLogSourceFactory.

BUG=733846
Review-Url: https://codereview.chromium.org/2956513004
Cr-Commit-Position: refs/heads/master@{#485283}
Committed: https://chromium.googlesource.com/chromium/src/+/dea6441d2d8033ee73d5f746c34be09c03ed4758

[Simon Que, 2017-06-23 05:36:43]

Description was changed from

==========
Rename SingleLogSource to SingleLogFileLogSource

Also refactored the use of SingleLogSource in feedbackPrivate API:
- Use the base interface class SystemLogsSource instead, in
  LogSourceAccessManager.
- Convert from feedback_private::LogSource directly to a
  SystemLogSource in SingleLogSourceFactory. Conversion of enums is
  internal to SingleLogSourceFactory.

BUG=733846
==========

to

==========
Rename SingleLogSource to SingleLogFileLogSource

Since there is now a class SingleDebugDaemonLogSource, the old
name "SingleLogSource" is ambiguous. Rename it to indicate that the
logs come from a log file.

Also refactored the use of SingleLogSource in feedbackPrivate API:
- Use the base interface class SystemLogsSource instead, in
  LogSourceAccessManager.
- Convert from feedback_private::LogSource directly to a
  SystemLogSource in SingleLogSourceFactory. Conversion of enums is
  internal to SingleLogSourceFactory.

BUG=733846
==========

[Simon Que, 2017-06-23 05:51:17]

sque@chromium.org changed reviewers:
+ afakhry@chromium.org

[Simon Que, 2017-06-23 05:51:18]

Please review chrome/browser/chromeos/system_logs.

I will ask tbarzic to review chrome/browser/extensions/api

[afakhry, 2017-06-24 00:08:52]

lgtm

[afakhry, 2017-06-24 00:10:17]

https://codereview.chromium.org/2956513004/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2956513004/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc:60:
return std::unique_ptr<SystemLogsSource>(new EmptySingleLogSource(type));
By the way MakeUnique<EmptySingleLogSource> should work here. Is it not?

[Simon Que, 2017-07-10 14:10:13]

https://codereview.chromium.org/2956513004/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2956513004/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc:60:
return std::unique_ptr<SystemLogsSource>(new EmptySingleLogSource(type));
On 2017/06/24 00:10:16, afakhry wrote:
> By the way MakeUnique<EmptySingleLogSource> should work here. Is it not?

Done.

[Simon Que, 2017-07-10 14:10:43]

The CQ bit was checked by sque@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 14:10:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 15:44:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 15:44:44]

Dry run: This issue passed the CQ dry run.

[Simon Que, 2017-07-10 15:51:13]

The CQ bit was checked by sque@chromium.org

[Simon Que, 2017-07-10 15:51:14]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/2956513004/#ps100001
(title: "Rebased")

[commit-bot: I haz the power, 2017-07-10 15:51:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 15:57:33]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499701873497520,
"parent_rev": "538f75da5a8e54f071ccacbf6d76c14e482686bf", "commit_rev":
"dea6441d2d8033ee73d5f746c34be09c03ed4758"}

[commit-bot: I haz the power, 2017-07-10 15:57:47]

Description was changed from

==========
Rename SingleLogSource to SingleLogFileLogSource

Since there is now a class SingleDebugDaemonLogSource, the old
name "SingleLogSource" is ambiguous. Rename it to indicate that the
logs come from a log file.

Also refactored the use of SingleLogSource in feedbackPrivate API:
- Use the base interface class SystemLogsSource instead, in
  LogSourceAccessManager.
- Convert from feedback_private::LogSource directly to a
  SystemLogSource in SingleLogSourceFactory. Conversion of enums is
  internal to SingleLogSourceFactory.

BUG=733846
==========

to

==========
Rename SingleLogSource to SingleLogFileLogSource

Since there is now a class SingleDebugDaemonLogSource, the old
name "SingleLogSource" is ambiguous. Rename it to indicate that the
logs come from a log file.

Also refactored the use of SingleLogSource in feedbackPrivate API:
- Use the base interface class SystemLogsSource instead, in
  LogSourceAccessManager.
- Convert from feedback_private::LogSource directly to a
  SystemLogSource in SingleLogSourceFactory. Conversion of enums is
  internal to SingleLogSourceFactory.

BUG=733846

Review-Url: https://codereview.chromium.org/2956513004
Cr-Commit-Position: refs/heads/master@{#485283}
Committed:
https://chromium.googlesource.com/chromium/src/+/dea6441d2d8033ee73d5f746c34b...
==========

[commit-bot: I haz the power, 2017-07-10 15:57:49]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/dea6441d2d8033ee73d5f746c34b...