Add SingleDebugDaemonLogSources to feedbackPrivate.readLogSource()

Add SingleDebugDaemonLogSources to feedbackPrivate.readLogSource()

The two supported log sources are:
- modetest
- lsusb

BUG=733846
Review-Url: https://codereview.chromium.org/2956623003
Cr-Commit-Position: refs/heads/master@{#485710}
Committed: https://chromium.googlesource.com/chromium/src/+/a135bf808de1da0ae1198d63b0f1901e42596c4f

[Simon Que, 2017-06-23 23:33:49]

Description was changed from

==========
Add debugd log sources to feedbackPrivate.readLogSource()

The two supported log sources are:
- modetest
- lsusb

BUG=733846
==========

to

==========
Add SingleDebugDaemonLogSources to feedbackPrivate.readLogSource()

The two supported log sources are:
- modetest
- lsusb

BUG=733846
==========

[Simon Que, 2017-06-23 23:35:00]

sque@chromium.org changed reviewers:
+ afakhry@chromium.org

[Simon Que, 2017-06-23 23:35:00]

This depends on the other CL, https://codereview.chromium.org/2956513004/

[afakhry, 2017-06-24 00:11:14]

lgtm

[Simon Que, 2017-07-10 19:09:42]

The CQ bit was checked by sque@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 19:10:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 20:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 20:18:26]

Dry run: This issue passed the CQ dry run.

[Simon Que, 2017-07-10 21:26:56]

The CQ bit was checked by sque@chromium.org

[Simon Que, 2017-07-10 21:26:56]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/2956623003/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2017-07-10 21:27:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 21:35:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 21:35:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Simon Que, 2017-07-10 21:37:56]

sque@chromium.org changed reviewers:
+ tbarzic@chromium.org

[Simon Que, 2017-07-10 21:37:56]

+tbarzic to review feedback_private.idl

[tbarzic, 2017-07-10 21:51:19]

https://codereview.chromium.org/2956623003/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/feedback_private.idl (right):

https://codereview.chromium.org/2956623003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/feedback_private.idl:110: modetest
this name seems very generic. Maybe something like displayModetest, or
display/displayInfo might be better?

[Simon Que, 2017-07-11 17:07:44]

https://codereview.chromium.org/2956623003/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/feedback_private.idl (right):

https://codereview.chromium.org/2956623003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/feedback_private.idl:110: modetest
On 2017/07/10 21:51:18, tbarzic wrote:
> this name seems very generic. Maybe something like displayModetest, or
> display/displayInfo might be better?

Done.

[tbarzic, 2017-07-11 17:12:59]

lgtm

[Simon Que, 2017-07-11 17:50:22]

The CQ bit was checked by sque@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 17:50:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 19:10:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 19:10:23]

Dry run: This issue passed the CQ dry run.

[Simon Que, 2017-07-11 19:19:52]

The CQ bit was checked by sque@chromium.org

[Simon Que, 2017-07-11 19:19:53]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/2956623003/#ps80001
(title: "Rename enum 'modetest' to 'drmModetest'")

[commit-bot: I haz the power, 2017-07-11 19:20:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 22:34:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499800792796900,
"parent_rev": "cae285de3cfae6a0b24adefcdbb56d5b67b46739", "commit_rev":
"4c4424876955010e8f24af8a07c77ca79bbd7a1f"}

[commit-bot: I haz the power, 2017-07-11 22:35:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499800792796900,
"parent_rev": "d73f07c3c79e360c3eb8e3605e24d29796b45185", "commit_rev":
"0824d0bf7235dcf94b036a067cf5d99b945f54a4"}

[commit-bot: I haz the power, 2017-07-11 22:35:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499800792796900,
"parent_rev": "b45467a31c1bd152920544cded6b571877d44846", "commit_rev":
"a135bf808de1da0ae1198d63b0f1901e42596c4f"}

[commit-bot: I haz the power, 2017-07-11 22:35:33]

Description was changed from

==========
Add SingleDebugDaemonLogSources to feedbackPrivate.readLogSource()

The two supported log sources are:
- modetest
- lsusb

BUG=733846
==========

to

==========
Add SingleDebugDaemonLogSources to feedbackPrivate.readLogSource()

The two supported log sources are:
- modetest
- lsusb

BUG=733846

Review-Url: https://codereview.chromium.org/2956623003
Cr-Commit-Position: refs/heads/master@{#485710}
Committed:
https://chromium.googlesource.com/chromium/src/+/a135bf808de1da0ae1198d63b0f1...
==========

[commit-bot: I haz the power, 2017-07-11 22:35:34]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a135bf808de1da0ae1198d63b0f1...