Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5199)

Unified Diff: chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc

Issue 2956513004: Rename SingleLogSource to SingleLogFileLogSource (Closed)
Patch Set: Rebased Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
diff --git a/chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc b/chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
index acef8a773dea36fba75223b11ea8ac0de19d161c..9e7f466d15d8c0d26aae5a64309d65ed4574d3e3 100644
--- a/chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
+++ b/chrome/browser/extensions/api/feedback_private/log_source_access_manager_chromeos_unittest.cc
@@ -19,10 +19,10 @@ namespace {
using api::feedback_private::LOG_SOURCE_MESSAGES;
using api::feedback_private::LOG_SOURCE_UILATEST;
+using api::feedback_private::LogSource;
using api::feedback_private::ReadLogSourceResult;
using api::feedback_private::ReadLogSourceParams;
-using system_logs::SingleLogSource;
-using SupportedSource = system_logs::SingleLogSource::SupportedSource;
+using system_logs::SystemLogsSource;
std::unique_ptr<KeyedService> ApiResourceManagerTestFactory(
content::BrowserContext* context) {
@@ -32,11 +32,12 @@ std::unique_ptr<KeyedService> ApiResourceManagerTestFactory(
// Dummy function used as a callback for FetchFromSource().
void OnFetchedFromSource(const ReadLogSourceResult& result) {}
-// A dummy SingleLogSource that does not require real system logs to be
+// A dummy SystemLogsSource that does not require real system logs to be
// available during testing. Always returns an empty result.
-class EmptySingleLogSource : public SingleLogSource {
+class EmptySingleLogSource : public system_logs::SystemLogsSource {
public:
- explicit EmptySingleLogSource(SupportedSource type) : SingleLogSource(type) {}
+ explicit EmptySingleLogSource(LogSource type)
+ : SystemLogsSource(api::feedback_private::ToString(type)) {}
~EmptySingleLogSource() override = default;
@@ -47,7 +48,7 @@ class EmptySingleLogSource : public SingleLogSource {
// Do not directly pass the result to the callback, because that's not how
// log sources actually work. Instead, simulate the asynchronous operation
- // of a SingleLogSource by invoking the callback separately.
+ // of a SystemLogsSource by invoking the callback separately.
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindOnce(callback, base::Owned(result_map)));
}
@@ -55,7 +56,7 @@ class EmptySingleLogSource : public SingleLogSource {
// Instantiates a new instance of this class. Does not retain ownership. Used
// to create a Callback that can be used to override the default behavior of
// SingleLogSourceFactory.
- static std::unique_ptr<SingleLogSource> Create(SupportedSource type) {
+ static std::unique_ptr<SystemLogsSource> Create(LogSource type) {
return base::MakeUnique<EmptySingleLogSource>(type);
}

Powered by Google App Engine
This is Rietveld 408576698