Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2955563002: MD Bookmarks: Initial screenreader accessibility improvements (Closed)

Created:
3 years, 6 months ago by tsergeant
Modified:
3 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Initial screenreader accessibility improvements This is an initial set of small improvements to screenreader accessibility in MD Bookmarks. In particular, - Marks up the sidebar tree, list and menus with correct roles - Adds labels to menu buttons - Hides the toast message from screenreaders when it is off screen These changes have been tested with ChromeVox only. BUG=735808 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2955563002 Cr-Commit-Position: refs/heads/master@{#483955} Committed: https://chromium.googlesource.com/chromium/src/+/dd2fc8cb88b8a63bc01fcf925be0c0c916304f9f

Patch Set 1 #

Patch Set 2 : More tweaks #

Patch Set 3 : Fix closure #

Patch Set 4 : Hide the undo button when toast is closed #

Total comments: 6

Patch Set 5 : Privatize and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -29 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/app.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/command_manager.html View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.html View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.js View 1 2 3 4 5 chunks +29 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.html View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.js View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/toast_manager.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/toast_manager.js View 1 2 3 5 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.html View 2 chunks +23 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/toast_manager_test.js View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (25 generated)
tsergeant
3 years, 5 months ago (2017-06-27 07:33:51 UTC) #17
calamity
https://codereview.chromium.org/2955563002/diff/100001/chrome/browser/resources/md_bookmarks/folder_node.js File chrome/browser/resources/md_bookmarks/folder_node.js (right): https://codereview.chromium.org/2955563002/diff/100001/chrome/browser/resources/md_bookmarks/folder_node.js#newcode44 chrome/browser/resources/md_bookmarks/folder_node.js:44: hasChildFolder_: { /** @private */ https://codereview.chromium.org/2955563002/diff/100001/chrome/browser/resources/md_bookmarks/toolbar.html File chrome/browser/resources/md_bookmarks/toolbar.html (right): ...
3 years, 5 months ago (2017-06-30 06:05:19 UTC) #20
tsergeant
https://codereview.chromium.org/2955563002/diff/100001/chrome/browser/resources/md_bookmarks/folder_node.js File chrome/browser/resources/md_bookmarks/folder_node.js (right): https://codereview.chromium.org/2955563002/diff/100001/chrome/browser/resources/md_bookmarks/folder_node.js#newcode44 chrome/browser/resources/md_bookmarks/folder_node.js:44: hasChildFolder_: { On 2017/06/30 06:05:18, calamity wrote: > /** ...
3 years, 5 months ago (2017-07-03 04:07:20 UTC) #21
calamity
lgtm
3 years, 5 months ago (2017-07-03 06:53:03 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955563002/120001
3 years, 5 months ago (2017-07-03 07:20:05 UTC) #28
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 07:25:33 UTC) #31
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/dd2fc8cb88b8a63bc01fcf925be0...

Powered by Google App Engine
This is Rietveld 408576698