Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2511)

Unified Diff: chrome/browser/resources/md_bookmarks/toolbar.html

Issue 2955563002: MD Bookmarks: Initial screenreader accessibility improvements (Closed)
Patch Set: Privatize and rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/toolbar.html
diff --git a/chrome/browser/resources/md_bookmarks/toolbar.html b/chrome/browser/resources/md_bookmarks/toolbar.html
index 529b3bdbd93a5fc8f15fc499edd40cb0fc223b26..9f077ac3d729302dfa33d5c71588e474d587fb2c 100644
--- a/chrome/browser/resources/md_bookmarks/toolbar.html
+++ b/chrome/browser/resources/md_bookmarks/toolbar.html
@@ -55,6 +55,7 @@
<button is="paper-icon-button-light"
id="menuButton"
class="more-actions more-vert-button"
+ title="$i18n{organizeButtonTitle}"
on-tap="onMenuButtonOpenTap_">
<div></div>
<div></div>
@@ -62,26 +63,38 @@
</button>
</cr-toolbar>
<template is="cr-lazy-render" id="dropdown">
- <dialog is="cr-action-menu">
- <button class="dropdown-item" on-tap="onSortTap_"
- disabled="[[!canChangeList_]]">
+ <dialog is="cr-action-menu" role="menu">
+ <button class="dropdown-item"
+ on-tap="onSortTap_"
+ disabled="[[!canChangeList_]]"
+ role="menuitem">
$i18n{menuSort}
</button>
<hr>
- <button id="addBookmarkButton" class="dropdown-item"
- on-tap="onAddBookmarkTap_" disabled="[[!canChangeList_]]">
+ <button id="addBookmarkButton"
+ class="dropdown-item"
+ on-tap="onAddBookmarkTap_"
+ disabled="[[!canChangeList_]]"
+ role="menuitem">
$i18n{menuAddBookmark}
</button>
- <button class="dropdown-item" on-tap="onAddFolderTap_"
- disabled="[[!canChangeList_]]">
+ <button class="dropdown-item"
+ on-tap="onAddFolderTap_"
+ disabled="[[!canChangeList_]]"
+ role="menuitem">
$i18n{menuAddFolder}
</button>
<hr>
- <button id="importBookmarkButton" class="dropdown-item"
- on-tap="onImportTap_" disabled="[[!globalCanEdit_]]">
+ <button id="importBookmarkButton"
+ class="dropdown-item"
+ on-tap="onImportTap_"
+ disabled="[[!globalCanEdit_]]"
+ role="menuitem">
$i18n{menuImport}
</button>
- <button class="dropdown-item" on-tap="onExportTap_">
+ <button class="dropdown-item"
+ on-tap="onExportTap_"
+ role="menuitem">
$i18n{menuExport}
</button>
</dialog>
« no previous file with comments | « chrome/browser/resources/md_bookmarks/toast_manager.js ('k') | chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698