Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2470)

Unified Diff: chrome/browser/resources/md_bookmarks/folder_node.html

Issue 2955563002: MD Bookmarks: Initial screenreader accessibility improvements (Closed)
Patch Set: Privatize and rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/folder_node.html
diff --git a/chrome/browser/resources/md_bookmarks/folder_node.html b/chrome/browser/resources/md_bookmarks/folder_node.html
index deb4b1c53c1db5a0150494737e8c8d0e2ef8ba2c..e72f981dbae52ef8304d27f089a8b0e63aee7c39 100644
--- a/chrome/browser/resources/md_bookmarks/folder_node.html
+++ b/chrome/browser/resources/md_bookmarks/folder_node.html
@@ -86,8 +86,9 @@
on-tap="selectFolder_"
on-contextmenu="onContextMenu_"
tabindex$="[[getTabIndex_(isSelectedFolder_)]]"
- hidden="[[isRootFolder_(depth)]]">
- <template is="dom-if" if="[[hasChildFolder_(item_.children)]]">
+ hidden="[[isRootFolder_(depth)]]"
+ role="treeitem">
+ <template is="dom-if" if="[[hasChildFolder_]]">
<button is="paper-icon-button-light" id="arrow"
on-tap="toggleFolder_" on-mousedown="preventDefault_" tabindex="-1">
<iron-icon icon="cr:arrow-drop-down" is-open$="[[!isClosed_]]">
@@ -96,12 +97,12 @@
</template>
<div id="folder-label" class="v-centered">
<iron-icon icon="[[getFolderIcon_(isSelectedFolder_)]]"
- no-children$="[[!hasChildFolder_(item_.children)]]">
+ no-children$="[[!hasChildFolder_]]">
</iron-icon>
<div class="menu-label">[[item_.title]]</div>
</div>
</div>
- <div id="descendants" hidden$="[[isClosed_]]">
+ <div id="descendants" hidden$="[[isClosed_]]" role="group">
<template is="dom-repeat"
items="[[item_.children]]"
as="child"
« no previous file with comments | « chrome/browser/resources/md_bookmarks/compiled_resources2.gyp ('k') | chrome/browser/resources/md_bookmarks/folder_node.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698