Refactor PDFiumEngine::SelectionChangeInvalidator.

Refactor PDFiumEngine::SelectionChangeInvalidator.

- Use more of the initializer list.
- Rename GetVisibleSelectionsScreenRects() to GetVisibleSelections().
- Change GetVisibleSelections() to just return the rects, slightly
  simplify its implementation, and mark it as a const method.

Review-Url: https://codereview.chromium.org/2954803002
Cr-Commit-Position: refs/heads/master@{#482427}
Committed: https://chromium.googlesource.com/chromium/src/+/934e9b11552ccd4f4ef0778d99106f839acdbb4f

[Lei Zhang, 2017-06-24 04:45:41]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-24 04:45:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 05:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 05:50:44]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-06-26 19:04:49]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2017-06-26 19:10:58]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-06-26 19:10:58]

lgtm

[commit-bot: I haz the power, 2017-06-26 19:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 19:11:12]

This CL has an open dependency (Issue 2955743002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Lei Zhang, 2017-06-26 20:52:11]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-06-26 20:52:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 21:59:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498510331960600, "parent_rev":
"7e5e955eb4ab56b4970578ed743616858ef77817", "commit_rev":
"934e9b11552ccd4f4ef0778d99106f839acdbb4f"}

[commit-bot: I haz the power, 2017-06-26 22:00:07]

Description was changed from

==========
Refactor PDFiumEngine::SelectionChangeInvalidator.

- Use more of the initializer list.
- Rename GetVisibleSelectionsScreenRects() to GetVisibleSelections().
- Change GetVisibleSelections() to just return the rects, slightly
  simplify its implementation, and mark it as a const method.
==========

to

==========
Refactor PDFiumEngine::SelectionChangeInvalidator.

- Use more of the initializer list.
- Rename GetVisibleSelectionsScreenRects() to GetVisibleSelections().
- Change GetVisibleSelections() to just return the rects, slightly
  simplify its implementation, and mark it as a const method.

Review-Url: https://codereview.chromium.org/2954803002
Cr-Commit-Position: refs/heads/master@{#482427}
Committed:
https://chromium.googlesource.com/chromium/src/+/934e9b11552ccd4f4ef0778d9910...
==========

[commit-bot: I haz the power, 2017-06-26 22:00:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/934e9b11552ccd4f4ef0778d9910...