Only call PDFiumEngine::OnSelectionChanged() when there are changes.

Only call PDFiumEngine::OnSelectionChanged() when there are changes.

Otherwise, the PDF plugin will try to change the selection clipboard all
the time when selection, even for the tiniest mouse movement. Doing so
generates a lot of unnecessary IPC calls.

Review-Url: https://codereview.chromium.org/2955743002
Cr-Commit-Position: refs/heads/master@{#482371}
Committed: https://chromium.googlesource.com/chromium/src/+/88dd64554bd5471c3d2cb43aafa18f4e60505d0e

[Lei Zhang, 2017-06-24 04:22:29]

Description was changed from

==========
Only call PDFiumEngine::OnSelectionChanged() when there are changes.
==========

to

==========
Only call PDFiumEngine::OnSelectionChanged() when there are changes.

Otherwise, the PDF plugin will try to change the selection clipboard all
the time, even for the tiniest mouse movement while selecting. Doing so
generates a lot of unnecessary IPC calls.
==========

[Lei Zhang, 2017-06-24 04:22:47]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-24 04:22:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-06-24 04:23:42]

Description was changed from

==========
Only call PDFiumEngine::OnSelectionChanged() when there are changes.

Otherwise, the PDF plugin will try to change the selection clipboard all
the time, even for the tiniest mouse movement while selecting. Doing so
generates a lot of unnecessary IPC calls.
==========

to

==========
Only call PDFiumEngine::OnSelectionChanged() when there are changes.

Otherwise, the PDF plugin will try to change the selection clipboard all
the time when selection, even for the tiniest mouse movement. Doing so
generates a lot of unnecessary IPC calls.
==========

[commit-bot: I haz the power, 2017-06-24 05:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 05:27:30]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-06-26 19:04:18]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2017-06-26 19:08:55]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-06-26 19:08:55]

lgtm

[commit-bot: I haz the power, 2017-06-26 19:09:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 20:09:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498504135563030, "parent_rev":
"3de5e2e5cda4897500ece200edad554f0bb26d4f", "commit_rev":
"88dd64554bd5471c3d2cb43aafa18f4e60505d0e"}

[commit-bot: I haz the power, 2017-06-26 20:09:29]

Description was changed from

==========
Only call PDFiumEngine::OnSelectionChanged() when there are changes.

Otherwise, the PDF plugin will try to change the selection clipboard all
the time when selection, even for the tiniest mouse movement. Doing so
generates a lot of unnecessary IPC calls.
==========

to

==========
Only call PDFiumEngine::OnSelectionChanged() when there are changes.

Otherwise, the PDF plugin will try to change the selection clipboard all
the time when selection, even for the tiniest mouse movement. Doing so
generates a lot of unnecessary IPC calls.

Review-Url: https://codereview.chromium.org/2955743002
Cr-Commit-Position: refs/heads/master@{#482371}
Committed:
https://chromium.googlesource.com/chromium/src/+/88dd64554bd5471c3d2cb43aafa1...
==========

[commit-bot: I haz the power, 2017-06-26 20:09:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88dd64554bd5471c3d2cb43aafa1...