Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: pdf/pdfium/pdfium_engine.h

Issue 2954803002: Refactor PDFiumEngine::SelectionChangeInvalidator. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_engine.h
diff --git a/pdf/pdfium/pdfium_engine.h b/pdf/pdfium/pdfium_engine.h
index 5b0e4aa1d84b6858a06922827a6684a20d781a27..449efdf8e01064407cf3708522dd612526d7a7c5 100644
--- a/pdf/pdfium/pdfium_engine.h
+++ b/pdf/pdfium/pdfium_engine.h
@@ -135,15 +135,15 @@ class PDFiumEngine : public PDFEngine,
~SelectionChangeInvalidator();
private:
- // Sets the given container to the all the currently visible selection
- // rectangles, in screen coordinates.
- void GetVisibleSelectionsScreenRects(std::vector<pp::Rect>* rects);
+ // Returns all the currently visible selection rectangles, in screen
+ // coordinates.
+ std::vector<pp::Rect> GetVisibleSelections() const;
- PDFiumEngine* engine_;
+ PDFiumEngine* const engine_;
+ // The origin at the time this object was constructed.
+ const pp::Point previous_origin_;
// Screen rectangles that were selected on construction.
std::vector<pp::Rect> old_selections_;
- // The origin at the time this object was constructed.
- pp::Point previous_origin_;
};
// Used to store mouse down state to handle it in other mouse event handlers.
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698