Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2954503003: Don't show current RenderWidgetHostView while interstitial is showing. (Closed)

Created:
3 years, 6 months ago by Charlie Reis
Modified:
3 years, 6 months ago
Reviewers:
ncarter (slow), lfg
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Don't show current RenderWidgetHostView while interstitial is showing. Also moves interstitial page tracking from RenderFrameHostManager to WebContents, since interstitial pages are not frame-specific. This was necessary for subframes to detect if an interstitial page is showing. BUG=729105 TEST=See comment 13 of bug for repro steps CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2938313002 Cr-Original-Commit-Position: refs/heads/master@{#480117} Review-Url: https://codereview.chromium.org/2954503003 . Cr-Commit-Position: refs/branch-heads/3112@{#442} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/c958784507ff188871ddbe78461876aa8463d3cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -57 lines) Patch
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl_browsertest.cc View 2 chunks +48 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 3 chunks +4 lines, -23 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 12 chunks +18 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Charlie Reis
FYI: Merging to M60.
3 years, 6 months ago (2017-06-22 15:19:05 UTC) #2
Charlie Reis
3 years, 6 months ago (2017-06-22 15:28:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c958784507ff188871ddbe78461876aa8463d3cd.

Powered by Google App Engine
This is Rietveld 408576698