Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2938313002: Don't show current RenderWidgetHostView while interstitial is showing. (Closed)

Created:
3 years, 6 months ago by Charlie Reis
Modified:
3 years, 6 months ago
Reviewers:
ncarter (slow), lfg
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show current RenderWidgetHostView while interstitial is showing. Also moves interstitial page tracking from RenderFrameHostManager to WebContents, since interstitial pages are not frame-specific. This was necessary for subframes to detect if an interstitial page is showing. BUG=729105 TEST=See comment 13 of bug for repro steps CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2938313002 Cr-Commit-Position: refs/heads/master@{#480117} Committed: https://chromium.googlesource.com/chromium/src/+/adca986a53b31b6da4cb22f8e755f6856daea89a

Patch Set 1 #

Patch Set 2 : Move interstitial to WebContents, disable test in PlzNav #

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -57 lines) Patch
M content/browser/frame_host/interstitial_page_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl_browsertest.cc View 1 2 2 chunks +48 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_delegate.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 1 3 chunks +4 lines, -23 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 12 chunks +18 lines, -22 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Charlie Reis
Lucas, can you take a look, especially at RenderFrameHostManager::EnsureRenderFrameHostVisibilityConsistent() and the test? This avoids calling ...
3 years, 6 months ago (2017-06-16 17:02:49 UTC) #12
lfg
lgtm
3 years, 6 months ago (2017-06-16 18:28:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938313002/40001
3 years, 6 months ago (2017-06-16 19:06:30 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 19:12:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/adca986a53b31b6da4cb22f8e755...

Powered by Google App Engine
This is Rietveld 408576698