Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2954503003: Don't show current RenderWidgetHostView while interstitial is showing. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 3b589327633783567dc7972421fabc7545e49d34..62b879b0954ac63c07ea61721770e6c70a3fec8e 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -752,6 +752,7 @@ class CONTENT_EXPORT WebContentsImpl
RenderViewHost* new_host) override;
NavigationControllerImpl& GetControllerForRenderManager() override;
NavigationEntry* GetLastCommittedNavigationEntryForRenderManager() override;
+ InterstitialPageImpl* GetInterstitialForRenderManager() override;
bool FocusLocationBarByDefault() override;
void SetFocusToLocationBar(bool select_all) override;
bool IsHidden() override;
@@ -1349,6 +1350,12 @@ class CONTENT_EXPORT WebContentsImpl
// See ResumeLoadingCreatedWebContents.
bool is_resume_pending_;
+ // The interstitial page currently shown, if any. Not owned by this class: the
+ // InterstitialPage is self-owned and deletes itself asynchronously when
+ // hidden. Because it may outlive this WebContents, it enters a disabled state
+ // when hidden or preparing for destruction.
+ InterstitialPageImpl* interstitial_page_;
+
// Data for current page -----------------------------------------------------
// When a title cannot be taken from any entry, this title will be used.
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698