Less inequivalence on Hello World!

Less inequivalence on Hello World!

- generate runtime types from kernel
- remove Compiler.types and add ClosedWorld.types
- start checking emitter equivalence including Program model equivalence

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/2e6521678a53100476457c1da78bf5f3b961b222

[Johnni Winther, 2017-06-22 14:55:11]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-06-23 12:25:43]

PTAL

[Siggi Cherem (dart-lang), 2017-06-23 19:49:28]

lgtm

https://codereview.chromium.org/2954493002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart (left):

https://codereview.chromium.org/2954493002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart:296: call =
cls.lookupConstructorBody(Identifiers.call);
Was this basically dead code?

I'm guessing this used to be cls.lookupBackendMember, but we don't declare
`.call` in closures using addBackendMember because we create the entire class
explicitly, correct?

https://codereview.chromium.org/2954493002/diff/60001/tests/compiler/dart2js/...
File tests/compiler/dart2js/equivalence/check_functions.dart (right):

https://codereview.chromium.org/2954493002/diff/60001/tests/compiler/dart2js/...
tests/compiler/dart2js/equivalence/check_functions.dart:848: void
checkLibraries(Library library1, Library library2) {
suggestion
 - possibly rename to checkEmittedLibraries and checkEmittedClasses below? (just
to make the distinction clear, since the types don't have a namespace.), or
 - add the namespace with a prefix:

   checkClasses(emitter.Class c1, emitter.Class c2) { ... }

[Johnni Winther, 2017-06-26 09:17:44]

https://codereview.chromium.org/2954493002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart (left):

https://codereview.chromium.org/2954493002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart:296: call =
cls.lookupConstructorBody(Identifiers.call);
On 2017/06/23 19:49:28, Siggi Cherem (dart-lang) wrote:
> Was this basically dead code?
> 
> I'm guessing this used to be cls.lookupBackendMember, but we don't declare
> `.call` in closures using addBackendMember because we create the entire class
> explicitly, correct? 

Yes. Yes.

https://codereview.chromium.org/2954493002/diff/60001/tests/compiler/dart2js/...
File tests/compiler/dart2js/equivalence/check_functions.dart (right):

https://codereview.chromium.org/2954493002/diff/60001/tests/compiler/dart2js/...
tests/compiler/dart2js/equivalence/check_functions.dart:848: void
checkLibraries(Library library1, Library library2) {
On 2017/06/23 19:49:28, Siggi Cherem (dart-lang) wrote:
> suggestion
>  - possibly rename to checkEmittedLibraries and checkEmittedClasses below?
(just
> to make the distinction clear, since the types don't have a namespace.), or
>  - add the namespace with a prefix:
> 
>    checkClasses(emitter.Class c1, emitter.Class c2) { ... }

Renamed functions to checkEmitter*

[Johnni Winther, 2017-06-26 09:30:18]

Description was changed from

==========
Less inequivalence on Hello World!

- generate runtime types from kernel
- remove Compiler.types and add ClosedWorld.types
- start checking emitter equivalence including Program model equivalence
==========

to

==========
Less inequivalence on Hello World!

- generate runtime types from kernel
- remove Compiler.types and add ClosedWorld.types
- start checking emitter equivalence including Program model equivalence

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2e6521678a53100476457c1da78bf5f3b961b222
==========

[Johnni Winther, 2017-06-26 09:30:19]

Committed patchset #5 (id:80001) manually as
2e6521678a53100476457c1da78bf5f3b961b222 (presubmit successful).