pkg/compiler/lib/src/world.dart - Issue 2954493002: Less inequivalence on Hello World!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/world.dart

Issue 2954493002: Less inequivalence on Hello World! (Closed)

Patch Set: Updated cf. comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/universe/resolution_world_builder.dart ('k') | tests/compiler/dart2js/equivalence/check_functions.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/world.dart

diff --git a/pkg/compiler/lib/src/world.dart b/pkg/compiler/lib/src/world.dart

index abcf42605b864be283bb86792010070f4671c37a..b02f4671d6fa74b89f4720765fa1f11b8b1f5174 100644

--- a/pkg/compiler/lib/src/world.dart

+++ b/pkg/compiler/lib/src/world.dart

@@ -50,6 +50,8 @@ abstract class ClosedWorld implements World {

ElementEnvironment get elementEnvironment;

+ DartTypes get dartTypes;

CommonElements get commonElements;

CommonMasks get commonMasks;

@@ -433,6 +435,7 @@ abstract class ClosedWorldBase implements ClosedWorld, ClosedWorldRefiner {

CommonMasks _commonMasks;

final ElementEnvironment elementEnvironment;

+ final DartTypes dartTypes;

final CommonElements commonElements;

// TODO(johnniwinther): Avoid this.

@@ -443,6 +446,7 @@ abstract class ClosedWorldBase implements ClosedWorld, ClosedWorldRefiner {

ClosedWorldBase(

{this.elementEnvironment,

+ this.dartTypes,

this.commonElements,

this.constantSystem,

this.nativeData,

@@ -1163,6 +1167,7 @@ abstract class ClosedWorldBase implements ClosedWorld, ClosedWorldRefiner {

class ClosedWorldImpl extends ClosedWorldBase {

ClosedWorldImpl(

{ElementEnvironment elementEnvironment,

+ DartTypes dartTypes,

CommonElements commonElements,

ConstantSystem constantSystem,

NativeData nativeData,

@@ -1178,6 +1183,7 @@ class ClosedWorldImpl extends ClosedWorldBase {

Map<ClassEntity, ClassSet> classSets})

: super(

elementEnvironment: elementEnvironment,

+ dartTypes: dartTypes,

commonElements: commonElements,

constantSystem: constantSystem,

nativeData: nativeData,