Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/compiler/lib/src/compile_time_constants.dart

Issue 2954493002: Less inequivalence on Hello World! (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compile_time_constants.dart
diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart
index 2b56fd7b14cbb441ae693f020d0dfd9ca03b55bc..392431b00093f38cd293e5a48d72643908893847 100644
--- a/pkg/compiler/lib/src/compile_time_constants.dart
+++ b/pkg/compiler/lib/src/compile_time_constants.dart
@@ -279,7 +279,7 @@ abstract class ConstantCompilerBase implements ConstantCompiler {
} else {
ResolutionDartType constantType = value.getType(commonElements);
if (!constantSystem.isSubtype(
- compiler.types, constantType, elementType)) {
+ compiler.resolution.types, constantType, elementType)) {
if (isConst) {
reporter.reportErrorMessage(node, MessageKind.NOT_ASSIGNABLE,
{'fromType': constantType, 'toType': elementType});
@@ -1215,7 +1215,7 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
element.type.substByContext(constructedType);
ResolutionDartType constantType = constant.value.getType(commonElements);
if (!constantSystem.isSubtype(
- compiler.types, constantType, elementType)) {
+ compiler.resolution.types, constantType, elementType)) {
reporter.withCurrentElement(constant.element, () {
reporter.reportErrorMessage(constant.node, MessageKind.NOT_ASSIGNABLE,
{'fromType': constantType, 'toType': elementType});
« no previous file with comments | « no previous file | pkg/compiler/lib/src/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698