Fixing SelectionPopupController.isInsertion() race condition

Fixing SelectionPopupController.isInsertion() race condition

After my context menu refactor (crrev.com/2785853002),
SelectionPopupController.createActionMenu() and the setting of mIsInsertion
happened on two different threads. This lead to a race-condition in
SelectionPopupController.createActionMenu() since it relied on isInsertion().
This CL removes the race-condition by relying on hasSelection() instead of
isInsertion().

BUG=730996
Review-Url: https://codereview.chromium.org/2954023002
Cr-Commit-Position: refs/heads/master@{#481789}
Committed: https://chromium.googlesource.com/chromium/src/+/7bd2df286b3779e6311c214e3054260870a18c48

[amaralp, 2017-06-23 00:33:55]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 00:34:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2017-06-23 00:35:44]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org

[amaralp, 2017-06-23 00:35:45]

PTAL

[amaralp, 2017-06-23 00:56:22]

On 2017/06/23 at 00:35:45, amaralp wrote:
> PTAL

Renamed to isInsertionForTesting

[aelias_OOO_until_Jul13, 2017-06-23 01:24:34]

lgtm

[amaralp, 2017-06-23 01:25:02]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2017-06-23 01:25:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 02:16:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498181102754680,
"parent_rev": "b01b9a7f83ad1ed8247f6b4c907996270e1ed611", "commit_rev":
"7bd2df286b3779e6311c214e3054260870a18c48"}

[commit-bot: I haz the power, 2017-06-23 02:16:16]

Description was changed from

==========
Fixing SelectionPopupController.isInsertion() race condition

After my context menu refactor (crrev.com/2785853002),
SelectionPopupController.createActionMenu() and the setting of mIsInsertion
happened on two different threads. This lead to a race-condition in
SelectionPopupController.createActionMenu() since it relied on isInsertion().
This CL removes the race-condition by relying on hasSelection() instead of
isInsertion().

BUG=730996
==========

to

==========
Fixing SelectionPopupController.isInsertion() race condition

After my context menu refactor (crrev.com/2785853002),
SelectionPopupController.createActionMenu() and the setting of mIsInsertion
happened on two different threads. This lead to a race-condition in
SelectionPopupController.createActionMenu() since it relied on isInsertion().
This CL removes the race-condition by relying on hasSelection() instead of
isInsertion().

BUG=730996

Review-Url: https://codereview.chromium.org/2954023002
Cr-Commit-Position: refs/heads/master@{#481789}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bd2df286b3779e6311c214e3054...
==========

[commit-bot: I haz the power, 2017-06-23 02:16:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7bd2df286b3779e6311c214e3054...