Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2165)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2954023002: Fixing SelectionPopupController.isInsertion() race condition (Closed)
Patch Set: Renaming isInsertion to isInsertionForTesting Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index 2d72f2fe60c4061c09caca082eef0c3bcb48edb5..3d35612dd6f2eca19117c119ac9c5a959a9c2557 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -1186,7 +1186,7 @@ public class ImeTest {
@Override
public boolean isSatisfied() {
return mRule.getSelectionPopupController().isPastePopupShowing()
- && mRule.getSelectionPopupController().isInsertion();
+ && mRule.getSelectionPopupController().isInsertionForTesting();
}
});
@@ -1197,7 +1197,7 @@ public class ImeTest {
return !mRule.getSelectionPopupController().isPastePopupShowing();
}
});
- Assert.assertFalse(mRule.getSelectionPopupController().isInsertion());
+ Assert.assertFalse(mRule.getSelectionPopupController().isInsertionForTesting());
}
@Test
« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698