content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java - Issue 2954023002: Fixing SelectionPopupController.isInsertion() race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

Issue 2954023002: Fixing SelectionPopupController.isInsertion() race condition (Closed)

Patch Set: Renaming isInsertion to isInsertionForTesting Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

index 1756bc7a8b4f8d562d3b72e5d789754c10866900..3addf2585941bee18ad4aa38e1b5e0e75b842dea 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

@@ -867,7 +867,7 @@ public class ContentViewCoreSelectionTest {

CriteriaHelper.pollUiThread(Criteria.equals(show, new Callable<Boolean>() {

@Override

public Boolean call() {

- return mSelectionPopupController.isInsertion();

+ return mSelectionPopupController.isInsertionForTesting();

}

}));

}