[Extensions Bindings] Add access checks in custom types

[Extensions Bindings] Add access checks in custom types

Custom types (such as StorageArea and ChromeSetting/ContentSetting)
don't go through the typical sendRequest flow from APIBinding, and thus
avoid the access check that's there. Add an access check in these native
types.

BUG=653596
Review-Url: https://codereview.chromium.org/2953453002
Cr-Commit-Position: refs/heads/master@{#481559}
Committed: https://chromium.googlesource.com/chromium/src/+/72276223d2147fb370ec646329f01482e2056931

[Devlin, 2017-06-20 18:17:30]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 18:17:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 19:50:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 19:50:06]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-20 20:34:03]

Description was changed from

==========
access checker
BUG=
==========

to

==========
[Extensions Bindings] Add access checks in custom types

Custom types (such as StorageArea and ChromeSetting/ContentSetting)
don't go through the typical sendRequest flow from APIBinding, and thus
avoid the access check that's there. Add an access check in these native
types.

BUG=653596
==========

[Devlin, 2017-06-20 23:03:05]

Patchset #1 (id:1) has been deleted

[Devlin, 2017-06-20 23:03:11]

Patchset #1 (id:20001) has been deleted

[Devlin, 2017-06-20 23:03:18]

Patchset #1 (id:40001) has been deleted

[Devlin, 2017-06-20 23:03:34]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-06-20 23:03:35]

following https://codereview.chromium.org/2947843004/

[jbroman, 2017-06-21 00:37:33]

lgtm

[lazyboy, 2017-06-22 00:10:25]

lgtm

https://codereview.chromium.org/2953453002/diff/60001/extensions/renderer/chr...
File extensions/renderer/chrome_setting.h (right):

https://codereview.chromium.org/2953453002/diff/60001/extensions/renderer/chr...
extensions/renderer/chrome_setting.h:75: const BindingAccessChecker*
access_checker_;
nit: const BindingAccessChecker* 'const' access_checker_

[Devlin, 2017-06-22 15:02:36]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 15:02:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-22 15:49:55]

https://codereview.chromium.org/2953453002/diff/60001/extensions/renderer/chr...
File extensions/renderer/chrome_setting.h (right):

https://codereview.chromium.org/2953453002/diff/60001/extensions/renderer/chr...
extensions/renderer/chrome_setting.h:75: const BindingAccessChecker*
access_checker_;
On 2017/06/22 00:10:25, lazyboy wrote:
> nit: const BindingAccessChecker* 'const' access_checker_

Done (also for storage_area and content_setting)

[commit-bot: I haz the power, 2017-06-22 16:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 16:29:05]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-22 16:36:43]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-22 16:36:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2953453002/#ps80001
(title: "lazyboy's")

[commit-bot: I haz the power, 2017-06-22 16:36:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 16:40:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498149403899650,
"parent_rev": "41c477c1f50d312865c33b4f4d71fa660520300d", "commit_rev":
"72276223d2147fb370ec646329f01482e2056931"}

[commit-bot: I haz the power, 2017-06-22 16:40:40]

Description was changed from

==========
[Extensions Bindings] Add access checks in custom types

Custom types (such as StorageArea and ChromeSetting/ContentSetting)
don't go through the typical sendRequest flow from APIBinding, and thus
avoid the access check that's there. Add an access check in these native
types.

BUG=653596
==========

to

==========
[Extensions Bindings] Add access checks in custom types

Custom types (such as StorageArea and ChromeSetting/ContentSetting)
don't go through the typical sendRequest flow from APIBinding, and thus
avoid the access check that's there. Add an access check in these native
types.

BUG=653596

Review-Url: https://codereview.chromium.org/2953453002
Cr-Commit-Position: refs/heads/master@{#481559}
Committed:
https://chromium.googlesource.com/chromium/src/+/72276223d2147fb370ec646329f0...
==========

[commit-bot: I haz the power, 2017-06-22 16:40:42]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/72276223d2147fb370ec646329f0...