Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: extensions/renderer/storage_area.h

Issue 2953453002: [Extensions Bindings] Add access checks in custom types (Closed)
Patch Set: lazyboy's Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/content_setting.cc ('k') | extensions/renderer/storage_area.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/storage_area.h
diff --git a/extensions/renderer/storage_area.h b/extensions/renderer/storage_area.h
index f5abaeb0c61406fd7f30c89acd7b94502ff4cd7c..e37e28c4a94df83da1be32e271ada2f2839d7d85 100644
--- a/extensions/renderer/storage_area.h
+++ b/extensions/renderer/storage_area.h
@@ -23,6 +23,7 @@ namespace extensions {
class APIEventHandler;
class APIRequestHandler;
class APITypeReferenceMap;
+class BindingAccessChecker;
// Implementation of the storage.StorageArea custom type used in the
// chrome.storage API.
@@ -30,7 +31,8 @@ class StorageArea {
public:
StorageArea(APIRequestHandler* request_handler,
const APITypeReferenceMap* type_refs,
- const std::string& name);
+ const std::string& name,
+ const BindingAccessChecker* access_checker);
~StorageArea();
// Creates a StorageArea object for the given context and property name.
@@ -40,7 +42,8 @@ class StorageArea {
const base::ListValue* property_values,
APIRequestHandler* request_handler,
APIEventHandler* event_handler,
- APITypeReferenceMap* type_refs);
+ APITypeReferenceMap* type_refs,
+ const BindingAccessChecker* access_checker);
void HandleFunctionCall(const std::string& method_name,
gin::Arguments* arguments);
@@ -52,6 +55,8 @@ class StorageArea {
std::string name_;
+ const BindingAccessChecker* const access_checker_;
+
DISALLOW_COPY_AND_ASSIGN(StorageArea);
};
« no previous file with comments | « extensions/renderer/content_setting.cc ('k') | extensions/renderer/storage_area.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698