[Extensions Bindings] Add access checks in custom types

extensions/renderer/chrome_setting.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/chrome_setting.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "extensions/renderer/api_event_handler.h"
 #include "extensions/renderer/api_request_handler.h"
 #include "extensions/renderer/api_signature.h"
 #include "extensions/renderer/api_type_reference_map.h"
+#include "extensions/renderer/binding_access_checker.h"
 #include "gin/arguments.h"
 #include "gin/handle.h"
 #include "gin/object_template_builder.h"
 
 namespace extensions {
 
 v8::Local<v8::Object> ChromeSetting::Create(
     v8::Isolate* isolate,
     const std::string& property_name,
     const base::ListValue* property_values,
     APIRequestHandler* request_handler,
     APIEventHandler* event_handler,
-    APITypeReferenceMap* type_refs) {
+    APITypeReferenceMap* type_refs,
+    const BindingAccessChecker* access_checker) {
   std::string pref_name;
   CHECK(property_values->GetString(0u, &pref_name));
   const base::DictionaryValue* value_spec = nullptr;
   CHECK(property_values->GetDictionary(1u, &value_spec));
 
   gin::Handle<ChromeSetting> handle = gin::CreateHandle(
       isolate, new ChromeSetting(request_handler, event_handler, type_refs,
-                                 pref_name, *value_spec));
+                                 access_checker, pref_name, *value_spec));
   return handle.ToV8().As<v8::Object>();
 }
 
 ChromeSetting::ChromeSetting(APIRequestHandler* request_handler,
                              APIEventHandler* event_handler,
                              const APITypeReferenceMap* type_refs,
+                             const BindingAccessChecker* access_checker,
                              const std::string& pref_name,
                              const base::DictionaryValue& set_value_spec)
     : request_handler_(request_handler),
       event_handler_(event_handler),
       type_refs_(type_refs),
+      access_checker_(access_checker),
       pref_name_(pref_name),
       argument_spec_(ArgumentType::OBJECT) {
   // The set() call takes an object { value: { type: <t> }, ... }, where <t>
   // is the custom set() argument specified above by value_spec.
   ArgumentSpec::PropertiesMap properties;
   {
     auto scope_spec = base::MakeUnique<ArgumentSpec>(ArgumentType::REF);
     scope_spec->set_ref("types.ChromeSettingScope");
     scope_spec->set_optional(true);
     properties["scope"] = std::move(scope_spec);
@@ skipping 72 matching lines @@
 
 void ChromeSetting::HandleFunction(const std::string& method_name,
                                    gin::Arguments* arguments) {
   v8::Isolate* isolate = arguments->isolate();
   v8::HandleScope handle_scope(isolate);
   v8::Local<v8::Context> context = arguments->GetHolderCreationContext();
 
   std::vector<v8::Local<v8::Value>> argument_list = arguments->GetAll();
 
   std::string full_name = "types.ChromeSetting." + method_name;
+
+  if (!access_checker_->HasAccessOrThrowError(context, full_name))
+    return;
+
   std::unique_ptr<base::ListValue> converted_arguments;
   v8::Local<v8::Function> callback;
   std::string error;
   if (!type_refs_->GetTypeMethodSignature(full_name)->ParseArgumentsToJSON(
           context, argument_list, *type_refs_, &converted_arguments, &callback,
           &error)) {
     arguments->ThrowTypeError("Invalid invocation");
     return;
   }
 
   converted_arguments->Insert(0u, base::MakeUnique<base::Value>(pref_name_));
   request_handler_->StartRequest(
       context, full_name, std::move(converted_arguments), callback,
       v8::Local<v8::Function>(), binding::RequestThread::UI);
 }
 
 }  // namespace extensions