Revert of Always update the omnibox URL when cancelling via onbeforeunload

Revert of Always update the omnibox URL when cancelling via onbeforeunload (patchset #7 id:110001 of https://codereview.chromium.org/2919593007/ )

Reason for revert:
This caused failures on browser_side_navigation_content_browsertests (WebContentsImplBrowserTest.DismissingBeforeUnloadDialogInvalidatesUrl). See: https://crbug.com/734835 for links to the builders.

Original issue's description:
> Always update the omnibox URL when cancelling via onbeforeunload
> 
> The problem was that browser-initiated, same-site navigations that are
> cancelled via a beforeunload dialog didn't send a INVALIDATE_TYPE_URL
> invalidation to the Browser, because this invalidation was done as
> result of the beforeunload ACK, and we never got a beforeunload ACK in
> that case in non-PlzNavigate.
> 
> PlzNavigate did not have this problem.
> 
> We already cleared the pending entry -- in WebContentsImpl::OnDialogClosed,
> just before we send the response to the RunJavaScriptDialog result. The fix
> is to invalidate the omnibox at the same moment.
> 
> BUG=721184
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2919593007
> Cr-Commit-Position: refs/heads/master@{#480598}
> Committed: https://chromium.googlesource.com/chromium/src/+/bcce9cb42a1578ba95ead8b64e66101a8ae5e40b

TBR=creis@chromium.org,clamy@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721184, 734835
Review-Url: https://codereview.chromium.org/2952483002
Cr-Commit-Position: refs/heads/master@{#480669}
Committed: https://chromium.googlesource.com/chromium/src/+/15f5b5b2ef86151279bbad41a0976375b9f40977

[pdr., 2017-06-20 00:56:37]

Created Revert of Always update the omnibox URL when cancelling via
onbeforeunload

[pdr., 2017-06-20 00:56:58]

Description was changed from

==========
Revert of Always update the omnibox URL when cancelling via onbeforeunload
(patchset #7 id:110001 of https://codereview.chromium.org/2919593007/ )

Reason for revert:
This caused failures on browser_side_navigation_content_browsertests
(WebContentsImplBrowserTest.DismissingBeforeUnloadDialogInvalidatesUrl). See:
https://crbug.com/734835 for links to the builders.

Original issue's description:
> Always update the omnibox URL when cancelling via onbeforeunload
> 
> The problem was that browser-initiated, same-site navigations that are
> cancelled via a beforeunload dialog didn't send a INVALIDATE_TYPE_URL
> invalidation to the Browser, because this invalidation was done as
> result of the beforeunload ACK, and we never got a beforeunload ACK in
> that case in non-PlzNavigate.
> 
> PlzNavigate did not have this problem.
> 
> We already cleared the pending entry -- in WebContentsImpl::OnDialogClosed,
> just before we send the response to the RunJavaScriptDialog result. The fix
> is to invalidate the omnibox at the same moment.
> 
> BUG=721184
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2919593007
> Cr-Commit-Position: refs/heads/master@{#480598}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bcce9cb42a1578ba95ead8b64e66...

TBR=creis@chromium.org,clamy@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721184
==========

to

==========
Revert of Always update the omnibox URL when cancelling via onbeforeunload
(patchset #7 id:110001 of https://codereview.chromium.org/2919593007/ )

Reason for revert:
This caused failures on browser_side_navigation_content_browsertests
(WebContentsImplBrowserTest.DismissingBeforeUnloadDialogInvalidatesUrl). See:
https://crbug.com/734835 for links to the builders.

Original issue's description:
> Always update the omnibox URL when cancelling via onbeforeunload
> 
> The problem was that browser-initiated, same-site navigations that are
> cancelled via a beforeunload dialog didn't send a INVALIDATE_TYPE_URL
> invalidation to the Browser, because this invalidation was done as
> result of the beforeunload ACK, and we never got a beforeunload ACK in
> that case in non-PlzNavigate.
> 
> PlzNavigate did not have this problem.
> 
> We already cleared the pending entry -- in WebContentsImpl::OnDialogClosed,
> just before we send the response to the RunJavaScriptDialog result. The fix
> is to invalidate the omnibox at the same moment.
> 
> BUG=721184
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2919593007
> Cr-Commit-Position: refs/heads/master@{#480598}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bcce9cb42a1578ba95ead8b64e66...

TBR=creis@chromium.org,clamy@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721184, 734835
==========

[pdr., 2017-06-20 00:57:05]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-06-20 00:57:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 00:58:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497920225455490, "parent_rev":
"cbac25a432e85afc77b6696c21d6216cbc225b39", "commit_rev":
"15f5b5b2ef86151279bbad41a0976375b9f40977"}

[commit-bot: I haz the power, 2017-06-20 00:58:16]

Description was changed from

==========
Revert of Always update the omnibox URL when cancelling via onbeforeunload
(patchset #7 id:110001 of https://codereview.chromium.org/2919593007/ )

Reason for revert:
This caused failures on browser_side_navigation_content_browsertests
(WebContentsImplBrowserTest.DismissingBeforeUnloadDialogInvalidatesUrl). See:
https://crbug.com/734835 for links to the builders.

Original issue's description:
> Always update the omnibox URL when cancelling via onbeforeunload
> 
> The problem was that browser-initiated, same-site navigations that are
> cancelled via a beforeunload dialog didn't send a INVALIDATE_TYPE_URL
> invalidation to the Browser, because this invalidation was done as
> result of the beforeunload ACK, and we never got a beforeunload ACK in
> that case in non-PlzNavigate.
> 
> PlzNavigate did not have this problem.
> 
> We already cleared the pending entry -- in WebContentsImpl::OnDialogClosed,
> just before we send the response to the RunJavaScriptDialog result. The fix
> is to invalidate the omnibox at the same moment.
> 
> BUG=721184
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2919593007
> Cr-Commit-Position: refs/heads/master@{#480598}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bcce9cb42a1578ba95ead8b64e66...

TBR=creis@chromium.org,clamy@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721184, 734835
==========

to

==========
Revert of Always update the omnibox URL when cancelling via onbeforeunload
(patchset #7 id:110001 of https://codereview.chromium.org/2919593007/ )

Reason for revert:
This caused failures on browser_side_navigation_content_browsertests
(WebContentsImplBrowserTest.DismissingBeforeUnloadDialogInvalidatesUrl). See:
https://crbug.com/734835 for links to the builders.

Original issue's description:
> Always update the omnibox URL when cancelling via onbeforeunload
> 
> The problem was that browser-initiated, same-site navigations that are
> cancelled via a beforeunload dialog didn't send a INVALIDATE_TYPE_URL
> invalidation to the Browser, because this invalidation was done as
> result of the beforeunload ACK, and we never got a beforeunload ACK in
> that case in non-PlzNavigate.
> 
> PlzNavigate did not have this problem.
> 
> We already cleared the pending entry -- in WebContentsImpl::OnDialogClosed,
> just before we send the response to the RunJavaScriptDialog result. The fix
> is to invalidate the omnibox at the same moment.
> 
> BUG=721184
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2919593007
> Cr-Commit-Position: refs/heads/master@{#480598}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bcce9cb42a1578ba95ead8b64e66...

TBR=creis@chromium.org,clamy@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721184, 734835

Review-Url: https://codereview.chromium.org/2952483002
Cr-Commit-Position: refs/heads/master@{#480669}
Committed:
https://chromium.googlesource.com/chromium/src/+/15f5b5b2ef86151279bbad41a097...
==========

[commit-bot: I haz the power, 2017-06-20 00:58:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15f5b5b2ef86151279bbad41a097...