Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2952483002: Revert of Always update the omnibox URL when cancelling via onbeforeunload (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 void RenderViewCreated(RenderViewHost* render_view_host) override; 574 void RenderViewCreated(RenderViewHost* render_view_host) override;
575 void RenderViewReady(RenderViewHost* render_view_host) override; 575 void RenderViewReady(RenderViewHost* render_view_host) override;
576 void RenderViewTerminated(RenderViewHost* render_view_host, 576 void RenderViewTerminated(RenderViewHost* render_view_host,
577 base::TerminationStatus status, 577 base::TerminationStatus status,
578 int error_code) override; 578 int error_code) override;
579 void RenderViewDeleted(RenderViewHost* render_view_host) override; 579 void RenderViewDeleted(RenderViewHost* render_view_host) override;
580 void UpdateTargetURL(RenderViewHost* render_view_host, 580 void UpdateTargetURL(RenderViewHost* render_view_host,
581 const GURL& url) override; 581 const GURL& url) override;
582 void Close(RenderViewHost* render_view_host) override; 582 void Close(RenderViewHost* render_view_host) override;
583 void RequestMove(const gfx::Rect& new_bounds) override; 583 void RequestMove(const gfx::Rect& new_bounds) override;
584 void DidCancelLoading() override;
584 void DocumentAvailableInMainFrame(RenderViewHost* render_view_host) override; 585 void DocumentAvailableInMainFrame(RenderViewHost* render_view_host) override;
585 void RouteCloseEvent(RenderViewHost* rvh) override; 586 void RouteCloseEvent(RenderViewHost* rvh) override;
586 bool DidAddMessageToConsole(int32_t level, 587 bool DidAddMessageToConsole(int32_t level,
587 const base::string16& message, 588 const base::string16& message,
588 int32_t line_no, 589 int32_t line_no,
589 const base::string16& source_id) override; 590 const base::string16& source_id) override;
590 RendererPreferences GetRendererPrefs( 591 RendererPreferences GetRendererPrefs(
591 BrowserContext* browser_context) const override; 592 BrowserContext* browser_context) const override;
592 void OnUserInteraction(RenderWidgetHostImpl* render_widget_host, 593 void OnUserInteraction(RenderWidgetHostImpl* render_widget_host,
593 const blink::WebInputEvent::Type type) override; 594 const blink::WebInputEvent::Type type) override;
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 912 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
912 TwoSubframesCreatePopupsSimultaneously); 913 TwoSubframesCreatePopupsSimultaneously);
913 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 914 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
914 TwoSubframesCreatePopupMenuWidgetsSimultaneously); 915 TwoSubframesCreatePopupMenuWidgetsSimultaneously);
915 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest, 916 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest,
916 CrossSiteIframeAccessibility); 917 CrossSiteIframeAccessibility);
917 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest, 918 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
918 JavaScriptDialogsInMainAndSubframes); 919 JavaScriptDialogsInMainAndSubframes);
919 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest, 920 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
920 DialogsFromJavaScriptEndFullscreen); 921 DialogsFromJavaScriptEndFullscreen);
921 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
922 DismissingBeforeUnloadDialogInvalidatesUrl);
923 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest, 922 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
924 IframeBeforeUnloadParentHang); 923 IframeBeforeUnloadParentHang);
925 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest, 924 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
926 BeforeUnloadDialogRequiresGesture); 925 BeforeUnloadDialogRequiresGesture);
927 926
928 // So |find_request_manager_| can be accessed for testing. 927 // So |find_request_manager_| can be accessed for testing.
929 friend class FindRequestManagerTest; 928 friend class FindRequestManagerTest;
930 929
931 // TODO(brettw) TestWebContents shouldn't exist! 930 // TODO(brettw) TestWebContents shouldn't exist!
932 friend class TestWebContents; 931 friend class TestWebContents;
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
1656 // Adds/removes a callback called on creation of each new WebContents. 1655 // Adds/removes a callback called on creation of each new WebContents.
1657 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1656 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1658 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1657 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1659 1658
1660 DISALLOW_COPY_AND_ASSIGN(FriendWrapper); 1659 DISALLOW_COPY_AND_ASSIGN(FriendWrapper);
1661 }; 1660 };
1662 1661
1663 } // namespace content 1662 } // namespace content
1664 1663
1665 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1664 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698