content/browser/web_contents/web_contents_impl.h - Issue 2952483002: Revert of Always update the omnibox URL when cancelling via onbeforeunload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2952483002: Revert of Always update the omnibox URL when cancelling via onbeforeunload (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 30cb08db3e1a5d55801da5e1e9855a21afc46e20..4ef2a60db79ea5c6185950e56c337f0dc6d587bc 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -581,6 +581,7 @@

const GURL& url) override;

void Close(RenderViewHost* render_view_host) override;

void RequestMove(const gfx::Rect& new_bounds) override;

+ void DidCancelLoading() override;

void DocumentAvailableInMainFrame(RenderViewHost* render_view_host) override;

void RouteCloseEvent(RenderViewHost* rvh) override;

bool DidAddMessageToConsole(int32_t level,

@@ -918,8 +919,6 @@

JavaScriptDialogsInMainAndSubframes);

FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,

DialogsFromJavaScriptEndFullscreen);

- FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,

- DismissingBeforeUnloadDialogInvalidatesUrl);

FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,

IframeBeforeUnloadParentHang);

FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,