DescriptionReland of [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary (patchset #1 id:1 of https://codereview.chromium.org/2953563002/ )
Reason for revert:
Builder recovered before the revert made it in.
Original issue's description:
> Revert of [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary (patchset #8 id:200001 of https://codereview.chromium.org/2869823003/ )
>
> Reason for revert:
> Speculative revert.
>
> The builder
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bu...
> fails with:
>
> FAILED: gesture_detection.dll gesture_detection.dll.lib
> gesture_detection.dll.pdb
> C:/b/depot_tools/python276_bin/python.exe
> ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
> link.exe /nologo /IMPLIB:./gesture_detection.dll.lib /DLL
> /OUT:./gesture_detection.dll /PDB:./gesture_detection.dll.pdb
> @./gesture_detection.dll.rsp
> LINK : fatal error LNK1104: cannot open file 'gfx_switches.dll.lib'
>
> The reverted CL touches code with gestures and gfx.
>
> Today's sheriff.
>
> Original issue's description:
> > [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary
> >
> > For a gesture event, we want to know whether the source touch event was handled
> > blocking or non-blocking, and we can flush the vsync queue immediately if it was
> > blocking.
> >
> > This patch will help avoid regression in |first_gesture_scroll_update_latency|
> > in |smoothness.tough_scrolling_cases|.
> >
> > After CL the process would be:
> > 1. Browser -> Renderer: Send touch
> > 2. Renderer -> Browser: Touch Ack
> > 3. Browser: Set |is_source_touch_event_set_non_blocking == true| if the ack was
> > |INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING*|
> > 4. Browser -> Renderer: Send generated gesture events with
> > |is_source_touch_event_set_non_blocking| bit
> > 5. Renderer: Flush vsync queue if |is_source_touch_event_set_non_blocking == true|.
> >
> > BUG=704732
> >
> > Review-Url: https://codereview.chromium.org/2869823003
> > Cr-Original-Commit-Position: refs/heads/master@{#480202}
> > Committed: https://chromium.googlesource.com/chromium/src/+/80553a96dc6712a24a7d0a3e3074d5b7f5f65338
> > Review-Url: https://codereview.chromium.org/2869823003
> > Cr-Commit-Position: refs/heads/master@{#481130}
> > Committed: https://chromium.googlesource.com/chromium/src/+/44f78150b462c4c9daaba7ae47a772fba104e56a
>
> TBR=dtapuska@chromium.org,sadrul@chromium.org,pfeldman@chromium.org,thestig@chromium.org,chongz@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=704732
>
> Review-Url: https://codereview.chromium.org/2953563002
> Cr-Commit-Position: refs/heads/master@{#481136}
> Committed: https://chromium.googlesource.com/chromium/src/+/6b8c880ce554510082ac8aaff2d86e58dd6df4bc
TBR=dtapuska@chromium.org,sadrul@chromium.org,pfeldman@chromium.org,thestig@chromium.org,chongz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704732
Review-Url: https://codereview.chromium.org/2951973002
Cr-Commit-Position: refs/heads/master@{#481140}
Committed: https://chromium.googlesource.com/chromium/src/+/1fa26761c2291efeec10eb180b4ee28fc5bc08b0
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|