Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 2953563002: Revert of [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary (Closed)

Created:
3 years, 6 months ago by vabr (Chromium)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jam, dtapuska+chromiumwatch_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary (patchset #8 id:200001 of https://codereview.chromium.org/2869823003/ ) Reason for revert: Speculative revert. The builder https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bu... fails with: FAILED: gesture_detection.dll gesture_detection.dll.lib gesture_detection.dll.pdb C:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /IMPLIB:./gesture_detection.dll.lib /DLL /OUT:./gesture_detection.dll /PDB:./gesture_detection.dll.pdb @./gesture_detection.dll.rsp LINK : fatal error LNK1104: cannot open file 'gfx_switches.dll.lib' The reverted CL touches code with gestures and gfx. Today's sheriff. Original issue's description: > [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary > > For a gesture event, we want to know whether the source touch event was handled > blocking or non-blocking, and we can flush the vsync queue immediately if it was > blocking. > > This patch will help avoid regression in |first_gesture_scroll_update_latency| > in |smoothness.tough_scrolling_cases|. > > After CL the process would be: > 1. Browser -> Renderer: Send touch > 2. Renderer -> Browser: Touch Ack > 3. Browser: Set |is_source_touch_event_set_non_blocking == true| if the ack was > |INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING*| > 4. Browser -> Renderer: Send generated gesture events with > |is_source_touch_event_set_non_blocking| bit > 5. Renderer: Flush vsync queue if |is_source_touch_event_set_non_blocking == true|. > > BUG=704732 > > Review-Url: https://codereview.chromium.org/2869823003 > Cr-Original-Commit-Position: refs/heads/master@{#480202} > Committed: https://chromium.googlesource.com/chromium/src/+/80553a96dc6712a24a7d0a3e3074d5b7f5f65338 > Review-Url: https://codereview.chromium.org/2869823003 > Cr-Commit-Position: refs/heads/master@{#481130} > Committed: https://chromium.googlesource.com/chromium/src/+/44f78150b462c4c9daaba7ae47a772fba104e56a TBR=dtapuska@chromium.org,sadrul@chromium.org,pfeldman@chromium.org,thestig@chromium.org,chongz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=704732 Review-Url: https://codereview.chromium.org/2953563002 Cr-Commit-Position: refs/heads/master@{#481136} Committed: https://chromium.googlesource.com/chromium/src/+/6b8c880ce554510082ac8aaff2d86e58dd6df4bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -145 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebInputEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebGestureEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 1 chunk +6 lines, -13 lines 0 comments Download
M ui/events/gesture_event_details.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ui/events/gestures/gesture_provider_aura.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/events/gestures/gesture_provider_aura.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M ui/events/gestures/gesture_recognizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vabr (Chromium)
Created Revert of [VSync Queue] Plug touch ack to gesture events and flush vsync queue ...
3 years, 6 months ago (2017-06-21 07:43:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953563002/1
3 years, 6 months ago (2017-06-21 07:43:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6b8c880ce554510082ac8aaff2d86e58dd6df4bc
3 years, 6 months ago (2017-06-21 07:44:36 UTC) #6
vabr (Chromium)
Strangely enough, the builder got green again before the revert made it into the blamelist. ...
3 years, 6 months ago (2017-06-21 08:05:53 UTC) #7
vabr (Chromium)
3 years, 6 months ago (2017-06-21 08:06:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2951973002/ by vabr@chromium.org.

The reason for reverting is: Builder recovered before the revert made it in..

Powered by Google App Engine
This is Rietveld 408576698