Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2951793003: [wasm] Implement remaining SIMD x64 compare ops, unops. (Closed)

Created:
3 years, 6 months ago by gdeepti
Modified:
3 years, 5 months ago
CC:
v8-reviews_googlegroups.com, bradnelson
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Implement remaining SIMD x64 compare ops, unops. Ops Implemented: I32x4Neg, I32x4GtS, I32x4GeS, I32x4GtU, I32x4GeU, I16x8Neg, I16x8GtS, I16x8GeS, I16x8GtU, I16x8GeU I8x16Neg, I8x16GtS, I8x16GeS, I8x16GtU, I8x16GeU S128Not BUG=v8:6020 R=bbudge@chromium.org, zvi.rackover@intel.com, mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2951793003 Cr-Commit-Position: refs/heads/master@{#46329} Committed: https://chromium.googlesource.com/v8/v8/+/3a9cd454237c55cea0cf0597b06d71e13cf1c894

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Fix bug #

Total comments: 9

Patch Set 4 : Use pmin/pmax instructions #

Total comments: 6

Patch Set 5 : Bill's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -79 lines) Patch
M src/compiler/instruction-selector.cc View 1 2 3 4 8 chunks +14 lines, -26 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 10 chunks +139 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 4 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 chunks +17 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 2 3 4 14 chunks +19 lines, -50 lines 0 comments Download

Messages

Total messages: 41 (23 generated)
gdeepti
https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc#newcode2284 src/compiler/x64/code-generator-x64.cc:2284: __ pxor(src, kScratchDoubleReg); This is similar to the code ...
3 years, 6 months ago (2017-06-21 03:44:01 UTC) #9
gdeepti
3 years, 6 months ago (2017-06-21 04:31:26 UTC) #13
bbudge
https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc#newcode2284 src/compiler/x64/code-generator-x64.cc:2284: __ pxor(src, kScratchDoubleReg); On 2017/06/21 03:44:01, gdeepti wrote: > ...
3 years, 6 months ago (2017-06-22 16:29:50 UTC) #14
gdeepti
https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc#newcode2284 src/compiler/x64/code-generator-x64.cc:2284: __ pxor(src, kScratchDoubleReg); On 2017/06/22 16:29:49, bbudge wrote: > ...
3 years, 6 months ago (2017-06-22 17:26:49 UTC) #15
gdeepti
3 years, 6 months ago (2017-06-22 17:26:51 UTC) #16
bbudge
A general question: can you reorder operands in the instruction selector so we can avoid ...
3 years, 6 months ago (2017-06-22 17:30:10 UTC) #17
zvi
On 2017/06/22 17:30:10, bbudge wrote: > A general question: can you reorder operands in the ...
3 years, 6 months ago (2017-06-24 23:03:05 UTC) #18
zvi
https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc#newcode2284 src/compiler/x64/code-generator-x64.cc:2284: __ pxor(src, kScratchDoubleReg); On 2017/06/22 17:26:48, gdeepti wrote: > ...
3 years, 6 months ago (2017-06-24 23:04:09 UTC) #19
gdeepti
https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc#newcode2254 src/compiler/x64/code-generator-x64.cc:2254: __ movaps(kScratchDoubleReg, i.InputSimd128Register(1)); On 2017/06/22 17:30:10, bbudge wrote: > ...
3 years, 5 months ago (2017-06-27 20:47:42 UTC) #24
zvi
https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc#newcode2284 src/compiler/x64/code-generator-x64.cc:2284: __ pxor(src, kScratchDoubleReg); On 2017/06/27 20:47:42, gdeepti wrote: > ...
3 years, 5 months ago (2017-06-27 22:30:32 UTC) #25
gdeepti
https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/40001/src/compiler/x64/code-generator-x64.cc#newcode2284 src/compiler/x64/code-generator-x64.cc:2284: __ pxor(src, kScratchDoubleReg); On 2017/06/27 22:30:32, zvi wrote: > ...
3 years, 5 months ago (2017-06-27 23:23:37 UTC) #26
bbudge
https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc#newcode2195 src/compiler/x64/code-generator-x64.cc:2195: __ psubd(dst, kScratchDoubleReg); Could you use PSIGNB/W/D instructions here? ...
3 years, 5 months ago (2017-06-28 00:05:08 UTC) #27
gdeepti
https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc#newcode2195 src/compiler/x64/code-generator-x64.cc:2195: __ psubd(dst, kScratchDoubleReg); On 2017/06/28 00:05:08, bbudge wrote: > ...
3 years, 5 months ago (2017-06-28 21:28:17 UTC) #30
bbudge
LGTM sorry to mis-direct you on GtU. https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc#newcode2281 src/compiler/x64/code-generator-x64.cc:2281: __ pxor(dst, ...
3 years, 5 months ago (2017-06-29 01:35:30 UTC) #33
gdeepti
+ mtrofin@/titzer@ for OWNERS in src/compiler. https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc#newcode2281 src/compiler/x64/code-generator-x64.cc:2281: __ pxor(dst, kScratchDoubleReg); ...
3 years, 5 months ago (2017-06-29 01:40:53 UTC) #35
titzer
On 2017/06/29 01:40:53, gdeepti wrote: > + mtrofin@/titzer@ for OWNERS in src/compiler. > > https://codereview.chromium.org/2951793003/diff/60001/src/compiler/x64/code-generator-x64.cc ...
3 years, 5 months ago (2017-06-29 08:52:10 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951793003/80001
3 years, 5 months ago (2017-06-29 16:05:55 UTC) #38
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 16:07:36 UTC) #41
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/3a9cd454237c55cea0cf0597b06d71e13cf...

Powered by Google App Engine
This is Rietveld 408576698