Update voice interaction icon shadow

Update voice interaction icon shadow

Use MD style shadow, also refactored how MD shadow values
are created.

BUG=b:35624617
TEST=build and flash locally, saw the shadow changes

Review-Url: https://codereview.chromium.org/2951583002
Cr-Commit-Position: refs/heads/master@{#481330}
Committed: https://chromium.googlesource.com/chromium/src/+/08a57486698031c8dc183e77503d8a54f8987ec8

[xc, 2017-06-19 21:07:54]

xiaohuic@chromium.org changed reviewers:
+ oshima@chromium.org, sky@chromium.org

[xc, 2017-06-19 21:07:55]

oshima@chromium.org: Please review changes in 
ash/shelf/*

sky@chromium.org: Please review changes in 
ui/gfx/*

[sky, 2017-06-19 21:48:27]

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h
File ui/gfx/shadow_value.h (right):

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h#newco...
ui/gfx/shadow_value.h:53: static const ShadowValues MakeShadowValues(int
elevation);
Remove the const.
Also, this needs a more descriptive name. MakeShadowValues is too generic.
Lastly, how much code is going to use this? I favor putting this in ash if ash
is the only placing that is going to use it.

[xc, 2017-06-19 21:57:18]

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h
File ui/gfx/shadow_value.h (right):

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h#newco...
ui/gfx/shadow_value.h:53: static const ShadowValues MakeShadowValues(int
elevation);
On 2017/06/19 21:48:27, sky wrote:
> Remove the const.
> Also, this needs a more descriptive name. MakeShadowValues is too generic.
> Lastly, how much code is going to use this? I favor putting this in ash if ash
> is the only placing that is going to use it.

MakeMDShadowValues?

This method is used by ash and gfx::ShadowDetails which is used in a number of
non-ash code. So I am not sure we can move it into ash without duplicating code.

[sky, 2017-06-20 16:21:49]

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h
File ui/gfx/shadow_value.h (right):

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h#newco...
ui/gfx/shadow_value.h:53: static const ShadowValues MakeShadowValues(int
elevation);
On 2017/06/19 21:57:18, xc wrote:
> On 2017/06/19 21:48:27, sky wrote:
> > Remove the const.
> > Also, this needs a more descriptive name. MakeShadowValues is too generic.
> > Lastly, how much code is going to use this? I favor putting this in ash if
ash
> > is the only placing that is going to use it.
> 
> MakeMDShadowValues?
> 
> This method is used by ash and gfx::ShadowDetails which is used in a number of
> non-ash code. So I am not sure we can move it into ash without duplicating
code.

Ok, I get it. I'm fine with MakeMdShadowValues.

[xc, 2017-06-21 03:28:24]

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h
File ui/gfx/shadow_value.h (right):

https://codereview.chromium.org/2951583002/diff/1/ui/gfx/shadow_value.h#newco...
ui/gfx/shadow_value.h:53: static const ShadowValues MakeShadowValues(int
elevation);
On 2017/06/20 16:21:49, sky wrote:
> On 2017/06/19 21:57:18, xc wrote:
> > On 2017/06/19 21:48:27, sky wrote:
> > > Remove the const.
> > > Also, this needs a more descriptive name. MakeShadowValues is too generic.
> > > Lastly, how much code is going to use this? I favor putting this in ash if
> ash
> > > is the only placing that is going to use it.
> > 
> > MakeMDShadowValues?
> > 
> > This method is used by ash and gfx::ShadowDetails which is used in a number
of
> > non-ash code. So I am not sure we can move it into ash without duplicating
> code.
> 
> Ok, I get it. I'm fine with MakeMdShadowValues. 

Updated the name.

[sky, 2017-06-21 14:52:25]

LGTM

[xc, 2017-06-21 16:54:51]

ping oshima@

[oshima, 2017-06-21 18:14:52]

lgtm once you fixed initializers.

https://codereview.chromium.org/2951583002/diff/60001/ash/shelf/voice_interac...
File ash/shelf/voice_interaction_overlay.cc (right):

https://codereview.chromium.org/2951583002/diff/60001/ash/shelf/voice_interac...
ash/shelf/voice_interaction_overlay.cc:90: gfx::Insets shadow_margin =
gfx::ShadowValue::GetMargin(shadow_values_);
nit: const

[xc, 2017-06-21 18:50:59]

https://codereview.chromium.org/2951583002/diff/60001/ash/shelf/voice_interac...
File ash/shelf/voice_interaction_overlay.cc (right):

https://codereview.chromium.org/2951583002/diff/60001/ash/shelf/voice_interac...
ash/shelf/voice_interaction_overlay.cc:90: gfx::Insets shadow_margin =
gfx::ShadowValue::GetMargin(shadow_values_);
On 2017/06/21 18:14:52, oshima wrote:
> nit: const

Done.

[xc, 2017-06-21 18:51:11]

The CQ bit was checked by xiaohuic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 18:51:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 21:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 21:16:56]

Dry run: This issue passed the CQ dry run.

[xc, 2017-06-21 22:14:46]

The CQ bit was checked by xiaohuic@chromium.org

[xc, 2017-06-21 22:14:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2951583002/#ps100001
(title: "fix const")

[commit-bot: I haz the power, 2017-06-21 22:15:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 22:20:07]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498083286438740,
"parent_rev": "c38a647148e276cefcf9550cbe36a493379c6d01", "commit_rev":
"08a57486698031c8dc183e77503d8a54f8987ec8"}

[commit-bot: I haz the power, 2017-06-21 22:20:22]

Description was changed from

==========
Update voice interaction icon shadow

Use MD style shadow, also refactored how MD shadow values
are created.

BUG=b:35624617
TEST=build and flash locally, saw the shadow changes
==========

to

==========
Update voice interaction icon shadow

Use MD style shadow, also refactored how MD shadow values
are created.

BUG=b:35624617
TEST=build and flash locally, saw the shadow changes

Review-Url: https://codereview.chromium.org/2951583002
Cr-Commit-Position: refs/heads/master@{#481330}
Committed:
https://chromium.googlesource.com/chromium/src/+/08a57486698031c8dc183e77503d...
==========

[commit-bot: I haz the power, 2017-06-21 22:20:23]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/08a57486698031c8dc183e77503d...