Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2951263002: [Signin] Add timeout to Dice token exchange requests (Closed)

Created:
3 years, 6 months ago by droger
Modified:
3 years, 6 months ago
Reviewers:
msarda
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin] Add timeout to Dice token exchange requests BUG=730589 Review-Url: https://codereview.chromium.org/2951263002 Cr-Commit-Position: refs/heads/master@{#481906} Committed: https://chromium.googlesource.com/chromium/src/+/159a49c29c076f9c5583c4607ca6965cd5ec4722

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -7 lines) Patch
M chrome/browser/signin/dice_response_handler.h View 1 5 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/signin/dice_response_handler.cc View 1 4 chunks +33 lines, -4 lines 0 comments Download
M chrome/browser/signin/dice_response_handler_unittest.cc View 5 chunks +24 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
droger
3 years, 6 months ago (2017-06-22 12:24:57 UTC) #4
msarda
lgtm
3 years, 6 months ago (2017-06-22 13:06:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951263002/60001
3 years, 6 months ago (2017-06-23 14:42:43 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 15:58:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/159a49c29c076f9c5583c4607ca6...

Powered by Google App Engine
This is Rietveld 408576698