[Signin] Add timeout to Dice token exchange requests

chrome/browser/signin/dice_response_handler_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/dice_response_handler.h"
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
-#include "base/test/test_simple_task_runner.h"
+#include "base/test/test_mock_time_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "base/time/time.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_header_helper.h"
 #include "components/signin/core/browser/test_signin_client.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "components/sync_preferences/testing_pref_service_syncable.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "google_apis/gaia/fake_oauth2_token_service_delegate.h"
 #include "net/url_request/url_request_test_util.h"
@@ skipping 27 matching lines @@
     // Pass |this| as a dummy consumer. Drop everything on the floor.
     return TestSigninClient::CreateGaiaAuthFetcher(this, source, getter);
   }
 
   GaiaAuthConsumer* consumer_;
 };
 
 class DiceResponseHandlerTest : public testing::Test {
  protected:
   DiceResponseHandlerTest()
-      : task_runner_(new base::TestSimpleTaskRunner()),
+      : loop_(base::MessageLoop::TYPE_IO),  // URLRequestContext requires IO.
+        task_runner_(new base::TestMockTimeTaskRunner()),
         request_context_getter_(
             new net::TestURLRequestContextGetter(task_runner_)),
         signin_client_(&pref_service_),
         token_service_(base::MakeUnique<FakeOAuth2TokenServiceDelegate>(
             request_context_getter_.get())),
         dice_response_handler_(&signin_client_,
                                &token_service_,
                                &account_tracker_service_) {
+    loop_.SetTaskRunner(task_runner_);
+    DCHECK_EQ(task_runner_, base::ThreadTaskRunnerHandle::Get());
     switches::EnableAccountConsistencyDiceForTesting(
         base::CommandLine::ForCurrentProcess());
     signin_client_.SetURLRequestContext(request_context_getter_.get());
     AccountTrackerService::RegisterPrefs(pref_service_.registry());
     account_tracker_service_.Initialize(&signin_client_);
   }
 
   ~DiceResponseHandlerTest() override {}
 
   DiceResponseParams MakeDiceParams(DiceAction action) {
     DiceResponseParams dice_params;
     dice_params.user_intention = action;
     dice_params.obfuscated_gaia_id = kObfuscatedGaiaID;
     dice_params.email = kEmail;
     dice_params.session_index = kSessionIndex;
     dice_params.authorization_code = kAuthorizationCode;
     return dice_params;
   }
 
   base::MessageLoop loop_;
-  scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+  scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
   scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
   sync_preferences::TestingPrefServiceSyncable pref_service_;
   DiceTestSigninClient signin_client_;
   ProfileOAuth2TokenService token_service_;
   AccountTrackerService account_tracker_service_;
   DiceResponseHandler dice_response_handler_;
 };
 
 // Checks that a SIGNIN action triggers a token exchange request.
 TEST_F(DiceResponseHandlerTest, Signin) {
@@ skipping 61 matching lines @@
   EXPECT_TRUE(
       token_service_.RefreshTokenIsAvailable(dice_params_1.obfuscated_gaia_id));
   // Simulate GaiaAuthFetcher success for the second request.
   consumer_2->OnClientOAuthSuccess(
       GaiaAuthConsumer::ClientOAuthResult("refresh_token", "access_token", 10));
   // Check that the token has been inserted in the token service.
   EXPECT_TRUE(
       token_service_.RefreshTokenIsAvailable(dice_params_2.obfuscated_gaia_id));
 }
 
+TEST_F(DiceResponseHandlerTest, Timeout) {
+  DiceResponseParams dice_params = MakeDiceParams(DiceAction::SIGNIN);
+  ASSERT_FALSE(
+      token_service_.RefreshTokenIsAvailable(dice_params.obfuscated_gaia_id));
+  dice_response_handler_.ProcessDiceHeader(dice_params);
+  // Check that a GaiaAuthFetcher has been created.
+  ASSERT_THAT(signin_client_.consumer_, testing::NotNull());
+  EXPECT_EQ(
+      1u, dice_response_handler_.GetPendingDiceTokenFetchersCountForTesting());
+  // Force a timeout.
+  task_runner_->FastForwardBy(
+      base::TimeDelta::FromSeconds(kDiceTokenFetchTimeoutSeconds + 1));
+  EXPECT_EQ(
+      0u, dice_response_handler_.GetPendingDiceTokenFetchersCountForTesting());
+}
+
 // Tests that the DiceResponseHandler is created for a normal profile but not
 // for an incognito profile.
 TEST(DiceResponseHandlerFactoryTest, NotInIncognito) {
   content::TestBrowserThreadBundle thread_bundle;
   TestingProfile profile;
   EXPECT_THAT(DiceResponseHandler::GetForProfile(&profile), testing::NotNull());
   EXPECT_THAT(
       DiceResponseHandler::GetForProfile(profile.GetOffTheRecordProfile()),
       testing::IsNull());
 }
 
 }  // namespace