Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 2944383006: [Signin] Rename obfuscated_gaia_id into gaia_id (Closed)

Created:
3 years, 6 months ago by droger
Modified:
3 years, 6 months ago
Reviewers:
msarda
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin] Rename obfuscated_gaia_id into gaia_id BUG=730589 Review-Url: https://codereview.chromium.org/2944383006 Cr-Commit-Position: refs/heads/master@{#481935} Committed: https://chromium.googlesource.com/chromium/src/+/3fc057c54155174850badc5c6b3bfd9b1ec2d955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -35 lines) Patch
M chrome/browser/signin/dice_response_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/dice_response_handler_unittest.cc View 7 chunks +12 lines, -21 lines 0 comments Download
M components/signin/core/browser/dice_header_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/signin/core/browser/signin_header_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/signin_header_helper_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
droger
3 years, 6 months ago (2017-06-22 13:12:00 UTC) #2
msarda
lgtm
3 years, 6 months ago (2017-06-22 13:15:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944383006/1
3 years, 6 months ago (2017-06-23 16:04:21 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 17:02:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3fc057c54155174850badc5c6b3b...

Powered by Google App Engine
This is Rietveld 408576698