[LayoutNG] Support objects that are opaque to whitespace collapsing

[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed and
used for bidi controls, but removed in [1] due to lack of spec and
tests. Above cases were tested in 4 browsers and re-implemented to be
interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609
Review-Url: https://codereview.chromium.org/2951213005
Cr-Commit-Position: refs/heads/master@{#482152}
Committed: https://chromium.googlesource.com/chromium/src/+/0a3ecc6715b7ad1c10bc6b4384d0bad5c8e0d165

[kojii, 2017-06-23 16:48:10]

Description was changed from

==========
ws

BUG=
==========

to

==========
ws

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-23 16:48:19]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 16:48:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 17:55:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 17:55:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kojii, 2017-06-23 18:26:21]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 18:26:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-23 18:28:41]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-06-23 18:30:05]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2017-06-23 18:31:25]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 18:31:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-23 18:41:08]

Description was changed from

==========
ws

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed, but
removed in [1] due to lack of spec and tests. All above cases were
tested in 4 browsers and re-implemented to be interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-23 18:41:49]

Description was changed from

==========
[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed, but
removed in [1] due to lack of spec and tests. All above cases were
tested in 4 browsers and re-implemented to be interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed and
used for bidi controls, but removed in [1] due to lack of spec and
tests. Above cases were tested in 4 browsers and re-implemented to be
interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-23 18:43:03]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-06-23 18:43:04]

PTAL.

[eae, 2017-06-23 18:49:09]

LGTM w/optional suggestion

https://codereview.chromium.org/2951213005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h
(right):

https://codereview.chromium.org/2951213005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h:70:
void AppendAsOpaqueToSpaceCollapsing(NGInlineItem::NGInlineItemType, UChar);
These names are a little too verbose, how about shortening it to AppendOpaque?

Thanks for the great comments explaining exactly what these methods do!

[kojii, 2017-06-23 18:59:37]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 19:00:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 19:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 19:20:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-06-23 19:53:41]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-06-23 19:53:52]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-06-23 19:54:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-23 19:55:43]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-06-23 19:56:20]

On 2017/06/23 at 18:49:09, eae wrote:
> These names are a little too verbose, how about shortening it to AppendOpaque?

I like it, thank you for the suggestion as always!

[kojii, 2017-06-23 19:56:27]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-06-23 19:56:28]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2951213005/#ps80001
(title: "Renamed to AppendOpaque")

[commit-bot: I haz the power, 2017-06-23 19:56:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 01:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 01:08:24]

Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[kojii, 2017-06-24 07:36:12]

Description was changed from

==========
[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed and
used for bidi controls, but removed in [1] due to lack of spec and
tests. Above cases were tested in 4 browsers and re-implemented to be
interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed and
used for bidi controls, but removed in [1] due to lack of spec and
tests. Above cases were tested in 4 browsers and re-implemented to be
interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609
==========

[kojii, 2017-06-24 07:36:14]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-06-24 07:36:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 17:20:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498289774609030,
"parent_rev": "6f23ef1f7305a75c2db96afde705bddcddde1f05", "commit_rev":
"0602c29d656c16a534a45e3af12d769b7e33b44b"}

[commit-bot: I haz the power, 2017-06-24 17:20:24]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498289774609030,
"parent_rev": "b2543b5d009a924286be4144384890f82d8cc180", "commit_rev":
"0a3ecc6715b7ad1c10bc6b4384d0bad5c8e0d165"}

[commit-bot: I haz the power, 2017-06-24 17:20:38]

Description was changed from

==========
[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed and
used for bidi controls, but removed in [1] due to lack of spec and
tests. Above cases were tested in 4 browsers and re-implemented to be
interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609
==========

to

==========
[LayoutNG] Support objects that are opaque to whitespace collapsing

This patch changes following objects opaque to whitespace collapsing;
i.e., spaces before such objects and after can collapse.
- Out-of-flow objects (floats, absolute positioned objects.)
- Open/close tags.
- Bidi controls.

The ability (AppendAsOpaqueToSpaceCollapsing) originally existed and
used for bidi controls, but removed in [1] due to lack of spec and
tests. Above cases were tested in 4 browsers and re-implemented to be
interoperable.

This patch also stops injecting Object Replacement Character for OOF
objects. This is not specified, and was not possible before, but
0-length item was supported for open/close tags, and this behavior is
interopeable with Blink/Edge/WebKit.

[1] https://codereview.chromium.org/2749013003

BUG=636993, 733609

Review-Url: https://codereview.chromium.org/2951213005
Cr-Commit-Position: refs/heads/master@{#482152}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a3ecc6715b7ad1c10bc6b4384d0...
==========

[commit-bot: I haz the power, 2017-06-24 17:20:40]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0a3ecc6715b7ad1c10bc6b4384d0...