Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc

Issue 2951213005: [LayoutNG] Support objects that are opaque to whitespace collapsing (Closed)
Patch Set: Renamed to AppendOpaque Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc
index dac3a1292c250aea7eaedbb1cb1efebf5e7e4b75..49323cc0cb853ef8c2fdbaaab09d92f56200b328 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc
@@ -220,6 +220,18 @@ TEST_F(NGInlineItemsBuilderTest, CollapseEastAsianWidth) {
"when both sides are Wide.";
}
+TEST_F(NGInlineItemsBuilderTest, OpaqueToSpaceCollapsing) {
+ NGInlineItemsBuilder builder(&items_);
+ builder.Append("Hello ", style_.Get());
+ builder.AppendOpaque(NGInlineItem::kBidiControl,
+ kFirstStrongIsolateCharacter);
+ builder.Append(" ", style_.Get());
+ builder.AppendOpaque(NGInlineItem::kBidiControl,
+ kFirstStrongIsolateCharacter);
+ builder.Append(" World", style_.Get());
+ EXPECT_EQ(String(u"Hello \u2068\u2068World"), builder.ToString());
+}
+
TEST_F(NGInlineItemsBuilderTest, CollapseAroundReplacedElement) {
NGInlineItemsBuilder builder(&items_);
builder.Append("Hello ", style_.Get());

Powered by Google App Engine
This is Rietveld 408576698