[LayoutNG] Fix whitespace collapsing when a node is a newline

[LayoutNG] Fix whitespace collapsing when a node is a newline

This patch fixes to handle a text node that contains only a collapsible
newline.

Before this change, collapsible newlines were lazily appended, when
following text is appended. When a text node contains only collapsible
newlines, NGLayoutInlineItemsBuilder does not keep the node and thus
unable to append lazily.

This patch changes to append pending collapsible newlines first, then
remove later if it needed to be collapsed.

BUG=636993
Review-Url: https://codereview.chromium.org/2749013003
Cr-Commit-Position: refs/heads/master@{#457339}
Committed: https://chromium.googlesource.com/chromium/src/+/3e651a1204f7bc387b1c077699e3a95348e1f525

[kojii, 2017-03-14 17:39:28]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 19:07:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:07:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-03-15 11:30:03]

Description was changed from

==========
ngws

BUG=
==========

to

==========
[LayoutNG] Fix whitespace collapsing when a node is a newline

This patch fixes to handle a text node that contains only a collapsible
newline.

Before this change, collapsible newlines were lazily appended, when
following text is appended. When a text node contains only collapsible
newlines, NGLayoutInlineItemsBuilder does not keep the node and thus
unable to append lazily.

This patch changes to append pending collapsible newlines first, then
remove later if it needed to be collapsed.

BUG=636993
==========

[kojii, 2017-03-15 11:31:23]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-03-15 11:31:23]

PTAL.

The crashes in the atomic inline CL I briefly mentioned turned out that because
whitespace collapsing was wrong.

[eae, 2017-03-15 16:22:10]

Good catch, this is great!

LGTM

[kojii, 2017-03-15 16:33:52]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-03-15 16:34:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 17:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:50:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-03-15 18:29:50]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-03-15 18:30:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:21:49]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kojii, 2017-03-16 02:38:31]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-03-16 02:38:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 03:34:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489631911585620, "parent_rev":
"5c0ad74ee97e52704cd1516ceecfb1873b0b5884", "commit_rev":
"3e651a1204f7bc387b1c077699e3a95348e1f525"}

[commit-bot: I haz the power, 2017-03-16 03:35:21]

Description was changed from

==========
[LayoutNG] Fix whitespace collapsing when a node is a newline

This patch fixes to handle a text node that contains only a collapsible
newline.

Before this change, collapsible newlines were lazily appended, when
following text is appended. When a text node contains only collapsible
newlines, NGLayoutInlineItemsBuilder does not keep the node and thus
unable to append lazily.

This patch changes to append pending collapsible newlines first, then
remove later if it needed to be collapsed.

BUG=636993
==========

to

==========
[LayoutNG] Fix whitespace collapsing when a node is a newline

This patch fixes to handle a text node that contains only a collapsible
newline.

Before this change, collapsible newlines were lazily appended, when
following text is appended. When a text node contains only collapsible
newlines, NGLayoutInlineItemsBuilder does not keep the node and thus
unable to append lazily.

This patch changes to append pending collapsible newlines first, then
remove later if it needed to be collapsed.

BUG=636993

Review-Url: https://codereview.chromium.org/2749013003
Cr-Commit-Position: refs/heads/master@{#457339}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e651a1204f7bc387b1c077699e3...
==========

[commit-bot: I haz the power, 2017-03-16 03:35:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e651a1204f7bc387b1c077699e3...