Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2951183002: [DevTools] Move inspector-protocol/accessibility tests to new harness (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, je_julie, dougt+watch_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, dmazzoni, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move inspector-protocol/accessibility tests to new harness BUG=734762 Review-Url: https://codereview.chromium.org/2951183002 Cr-Commit-Position: refs/heads/master@{#481641} Committed: https://chromium.googlesource.com/chromium/src/+/392f5835ae2f0bc78959763c57af3b41052a762e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+731 lines, -840 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html View 1 chunk +0 lines, -29 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.js View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getNodeWithNoAXNode.html View 1 chunk +0 lines, -20 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getNodeWithNoAXNode.js View 1 chunk +11 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getRelationships.html View 1 chunk +0 lines, -57 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getRelationships.js View 1 chunk +48 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getRelationships-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html View 1 chunk +0 lines, -64 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.js View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt View 3 chunks +1 line, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.html View 1 chunk +0 lines, -31 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.js View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal.html View 1 chunk +0 lines, -34 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal.js View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-buttons.html View 1 chunk +0 lines, -53 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-buttons.js View 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-buttons-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-img-figure.html View 1 chunk +0 lines, -76 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-img-figure.js View 1 chunk +68 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-img-figure-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input.html View 1 chunk +0 lines, -62 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input.js View 1 chunk +54 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-buttons.html View 1 chunk +0 lines, -70 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-buttons.js View 1 chunk +63 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-buttons-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-labelledby.html View 1 chunk +0 lines, -83 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-labelledby.js View 1 chunk +75 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-labelledby-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-summary.html View 1 chunk +0 lines, -57 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-summary.js View 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-summary-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-visiblity.html View 1 chunk +0 lines, -116 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-visiblity.js View 1 chunk +107 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-visiblity-expected.txt View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/resources/accessibility-dumpAccessibilityNodes.js View 8 chunks +70 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/stylesheet-tracking-restart.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2950713002 Patch 20001

Dependent Patchsets:

Issue 2950193003 Patch 1
Issue 2952023003 Patch 40001

Messages

Total messages: 9 (5 generated)
dgozman
Take a look please.
3 years, 6 months ago (2017-06-21 21:57:42 UTC) #2
lushnikov
lgtm
3 years, 6 months ago (2017-06-22 00:45:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951183002/1
3 years, 6 months ago (2017-06-22 16:58:21 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 20:06:00 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/392f5835ae2f0bc78959763c57af...

Powered by Google App Engine
This is Rietveld 408576698