Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2950193003: [DevTools] Migrate inspector-protocol/animation tests to new harness (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, devtools-reviews_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, darktears, blink-reviews, kozyatinskiy+blink_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate inspector-protocol/animation tests to new harness BUG=734762 Review-Url: https://codereview.chromium.org/2950193003 Cr-Commit-Position: refs/heads/master@{#481702} Committed: https://chromium.googlesource.com/chromium/src/+/e530921fff950ad4e2da1c99c1d61aa1e4eb5ef9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -625 lines) Patch
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-start.html View 1 chunk +0 lines, -35 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-start.js View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-create-start-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-css-replay.html View 1 chunk +0 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-css-replay.js View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-css-replay-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-empty-transition-cancel.html View 1 chunk +0 lines, -41 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-empty-transition-cancel.js View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-empty-transition-cancel-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-multiple-frames.html View 1 chunk +0 lines, -47 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-multiple-frames.js View 1 chunk +38 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.html View 1 chunk +0 lines, -60 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause.js View 1 chunk +27 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause-close.html View 1 chunk +0 lines, -39 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause-close.js View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause-close-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause-infinite.html View 1 chunk +0 lines, -60 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-pause-infinite.js View 1 chunk +27 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-paused-css-animation.html View 1 chunk +0 lines, -49 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-paused-css-animation.js View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-paused-css-animation-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-release.html View 1 chunk +0 lines, -65 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-release.js View 1 chunk +25 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-resolve.html View 1 chunk +0 lines, -38 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-resolve.js View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-resolve-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-seek-past-end.html View 1 chunk +0 lines, -51 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-seek-past-end.js View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-seek-past-end-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-start-cancel.html View 1 chunk +0 lines, -51 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-start-cancel.js View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-start-cancel-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-zero-duration.html View 1 chunk +0 lines, -49 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-zero-duration.js View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/animation/animation-zero-duration-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2951183002 Patch 1

Dependent Patchsets:

Issue 2952023003 Patch 1
Issue 2952023003 Patch 20001

Messages

Total messages: 8 (4 generated)
dgozman
Take a look please.
3 years, 6 months ago (2017-06-21 21:57:49 UTC) #2
lushnikov
lgtm
3 years, 6 months ago (2017-06-22 00:52:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950193003/1
3 years, 6 months ago (2017-06-22 21:04:36 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 22:58:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e530921fff950ad4e2da1c99c1d6...

Powered by Google App Engine
This is Rietveld 408576698