[DevTools] Migrate inspector-protocol/{console,cpu-profiler} to new harness

[DevTools] Migrate inspector-protocol/{console,cpu-profiler} to new harness

BUG=734762
Review-Url: https://codereview.chromium.org/2952023003
Cr-Commit-Position: refs/heads/master@{#481718}
Committed: https://chromium.googlesource.com/chromium/src/+/d3043821a09ddb2b598179f2c5363b281a4e857e

[dgozman, 2017-06-21 23:39:09]

dgozman@chromium.org changed reviewers:
+ alph@chromium.org

[dgozman, 2017-06-21 23:39:10]

Could you please take a look?

[alph, 2017-06-22 01:30:55]

lgtm

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.js
(right):

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.js:6:
testRunner.log('first \'let a = 1;\' result: wasThrown = ' +
!!response.result.exceptionDetails);
nit: you can use backquotes to avoid escaping.

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.js
(right):

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.js:31:
for (var i = 0; i < headers.length; i++) {
for-of

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profileEnd-parameterless-crash.js
(right):

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profileEnd-parameterless-crash.js:30:
for (var i = 0; i < headers.length; i++) {
for-of

[dgozman, 2017-06-22 17:14:32]

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.js
(right):

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.js:6:
testRunner.log('first \'let a = 1;\' result: wasThrown = ' +
!!response.result.exceptionDetails);
On 2017/06/22 01:30:54, alph wrote:
> nit: you can use backquotes to avoid escaping.

Done.

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.js
(right):

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.js:31:
for (var i = 0; i < headers.length; i++) {
On 2017/06/22 01:30:54, alph wrote:
> for-of

Done.

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profileEnd-parameterless-crash.js
(right):

https://codereview.chromium.org/2952023003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profileEnd-parameterless-crash.js:30:
for (var i = 0; i < headers.length; i++) {
On 2017/06/22 01:30:54, alph wrote:
> for-of

Done.

[dgozman, 2017-06-22 21:13:34]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-22 21:13:35]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2952023003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-06-22 21:14:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 23:28:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498166014486890,
"parent_rev": "1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54", "commit_rev":
"f30a1724e5a61f77e8ef7bed7711fed5582f3c41"}

[commit-bot: I haz the power, 2017-06-22 23:28:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498166014486890,
"parent_rev": "223c981c98e3ceb907115d2601c7c6a565295899", "commit_rev":
"d3043821a09ddb2b598179f2c5363b281a4e857e"}

[commit-bot: I haz the power, 2017-06-22 23:28:47]

Description was changed from

==========
[DevTools] Migrate inspector-protocol/{console,cpu-profiler} to new harness

BUG=734762
==========

to

==========
[DevTools] Migrate inspector-protocol/{console,cpu-profiler} to new harness

BUG=734762

Review-Url: https://codereview.chromium.org/2952023003
Cr-Commit-Position: refs/heads/master@{#481718}
Committed:
https://chromium.googlesource.com/chromium/src/+/d3043821a09ddb2b598179f2c536...
==========

[commit-bot: I haz the power, 2017-06-22 23:28:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d3043821a09ddb2b598179f2c536...