[DevTools] New harness for inspector-protocol layout tests

[DevTools] New harness for inspector-protocol layout tests

New harness loads a helper html file in a main testing window,
connects it to a browser-wide DevToolsAgentHost for manipulating pages
and evaluates the javascript test.

DevToolsProtocolTestBindings is a small implementation of
DevToolsAgentHost <--> harness communication (based on DevToolsFrontendHost).

Harness has a Page and Session class, which will make it possible to test
multiple sessions connected to the same page, and (if need arises) multiple
pages interaction.

Converted 4 tests to new harness. More to come.

BUG=734762
Review-Url: https://codereview.chromium.org/2950713002
Cr-Commit-Position: refs/heads/master@{#481419}
Committed: https://chromium.googlesource.com/chromium/src/+/454746093cd6f8d587a0c28818c500846c311cc9

[dgozman, 2017-06-20 00:48:26]

dgozman@chromium.org changed reviewers:
+ dpranke@chromium.org, einbinder@chromium.org, pfeldman@chromium.org

[dgozman, 2017-06-20 00:48:27]

Could you please take a look?

@dpranke: Tools/Scripts/webkitpy/layout_tests/port/base.py
@einbinder: LayoutTests/inspector-protocol/resources/inspector-protocol-test.js
@pfeldman: everything.

This is extracted from PoC https://codereview.chromium.org/2942573003/

Thanks,
Dmitry

[dgozman, 2017-06-20 22:10:18]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 22:10:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-06-20 22:21:52]

lgtm

[commit-bot: I haz the power, 2017-06-20 22:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 22:59:32]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Dirk Pranke, 2017-06-20 23:05:38]

lgtm

[einbinder, 2017-06-21 01:21:48]

lgtm

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js
(right):

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:117:
throw new Error();
Put the message in this error?

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:385:
errorMessage = errorMessage || 'Unexpected error';
errorMessage doesn't appear to be used anywhere.

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:428:
if (window.testRunner) {
Throw if no testRunner?

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:448:
DevToolsAPI._log(`${error}\n${error.stack}`);
Check that error isn't null/undefined here. Otherwise someone throwing null
might be an issue.

[dgozman, 2017-06-21 17:43:54]

Description was changed from

==========
[DevTools] New harness for inspector-protocol layout tests

New harness loads a helper html file in a main testing window,
connects it to a browser-wide DevToolsAgentHost for manipulating pages
and evaluates the javascript test.

DevToolsProtocolTestBindings is a small implementation of
DevToolsAgentHost <--> harness communication (based on DevToolsFrontendHost).

Harness has a Page and Session class, which will make it possible to test
multiple sessions connected to the same page, and (if need arises) multiple
pages interaction.

Converted a single to test to new harness. More to come.

BUG=734762
==========

to

==========
[DevTools] New harness for inspector-protocol layout tests

New harness loads a helper html file in a main testing window,
connects it to a browser-wide DevToolsAgentHost for manipulating pages
and evaluates the javascript test.

DevToolsProtocolTestBindings is a small implementation of
DevToolsAgentHost <--> harness communication (based on DevToolsFrontendHost).

Harness has a Page and Session class, which will make it possible to test
multiple sessions connected to the same page, and (if need arises) multiple
pages interaction.

Converted 4 tests to new harness. More to come.

BUG=734762
==========

[dgozman, 2017-06-21 18:11:47]

Thank you for review!

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js
(right):

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:117:
throw new Error();
On 2017/06/21 at 01:21:48, einbinder wrote:
> Put the message in this error?

Done.

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:385:
errorMessage = errorMessage || 'Unexpected error';
On 2017/06/21 at 01:21:48, einbinder wrote:
> errorMessage doesn't appear to be used anywhere.

Removed.

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:428:
if (window.testRunner) {
On 2017/06/21 at 01:21:48, einbinder wrote:
> Throw if no testRunner?

Done.

https://codereview.chromium.org/2950713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:448:
DevToolsAPI._log(`${error}\n${error.stack}`);
On 2017/06/21 at 01:21:48, einbinder wrote:
> Check that error isn't null/undefined here. Otherwise someone throwing null
might be an issue.

I think this one is an Error instance. I do check e.reason below since it can be
arbitrary thing.

[dgozman, 2017-06-21 18:11:57]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 18:12:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-06-21 20:20:17]

The CQ bit was unchecked by dgozman@chromium.org

[dgozman, 2017-06-21 20:20:20]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-21 20:20:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, einbinder@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2950713002/#ps20001
(title: "addressed comments, 4 tests")

[commit-bot: I haz the power, 2017-06-21 20:20:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 03:04:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498076420596130,
"parent_rev": "a6c93c251ce73dcbe7b2a01495ad5c92fa4d8943", "commit_rev":
"454746093cd6f8d587a0c28818c500846c311cc9"}

[commit-bot: I haz the power, 2017-06-22 03:04:54]

Description was changed from

==========
[DevTools] New harness for inspector-protocol layout tests

New harness loads a helper html file in a main testing window,
connects it to a browser-wide DevToolsAgentHost for manipulating pages
and evaluates the javascript test.

DevToolsProtocolTestBindings is a small implementation of
DevToolsAgentHost <--> harness communication (based on DevToolsFrontendHost).

Harness has a Page and Session class, which will make it possible to test
multiple sessions connected to the same page, and (if need arises) multiple
pages interaction.

Converted 4 tests to new harness. More to come.

BUG=734762
==========

to

==========
[DevTools] New harness for inspector-protocol layout tests

New harness loads a helper html file in a main testing window,
connects it to a browser-wide DevToolsAgentHost for manipulating pages
and evaluates the javascript test.

DevToolsProtocolTestBindings is a small implementation of
DevToolsAgentHost <--> harness communication (based on DevToolsFrontendHost).

Harness has a Page and Session class, which will make it possible to test
multiple sessions connected to the same page, and (if need arises) multiple
pages interaction.

Converted 4 tests to new harness. More to come.

BUG=734762

Review-Url: https://codereview.chromium.org/2950713002
Cr-Commit-Position: refs/heads/master@{#481419}
Committed:
https://chromium.googlesource.com/chromium/src/+/454746093cd6f8d587a0c28818c5...
==========

[commit-bot: I haz the power, 2017-06-22 03:04:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/454746093cd6f8d587a0c28818c5...